Details

Reviewers

Brecht Van Lommel (brecht)
Clément Foucault (fclem)

Maniphest Tasks

T63680: Overlay: Implement Mesh Analysis Overlay

Commits

rBS38a0896f1541: Overlay: Mesh Analysis
rB38a0896f1541: Overlay: Mesh Analysis

Summary

Enabling the drawing of the mesh analysis layers.
Currently the settings are part of the scene. What somehow makes sense, but does not fit well with the blender 2.80 overlays
but makes it not possible to draw a multiple mesh analysis at the same time.

I also did not spend time in optimizing/cleaning up the CPU based color determination. This is something we could do in a later patch.

Diff Detail

Repository

rB Blender

Branch

T63680 (branched from master)

Build Status

Buildable 3386
Build 3386: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Apr 19 2019, 2:49 PM

Harbormaster completed remote builds in B3382: Diff 14823.Apr 19 2019, 2:49 PM

Harbormaster completed remote builds in B3382: Diff 14823.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Apr 19 2019, 2:52 PM

Jeroen Bakker (jbakker) added reviewers: Brecht Van Lommel (brecht), Clément Foucault (fclem).

Jeroen Bakker (jbakker) added inline comments.Apr 19 2019, 2:57 PM

source/blender/draw/intern/draw_cache_impl_mesh.c
5259	Seems like a copy paste error. will remove
source/blender/draw/modes/edit_mesh_mode.c
541	Remove comment
697	remove comment

@Clément Foucault (fclem) can you take a special look into the naming convention inside the draw_cache?

Code style + cleanup

Harbormaster completed remote builds in B3384: Diff 14825.Apr 19 2019, 3:03 PM

Jeroen Bakker (jbakker) added inline comments.Apr 19 2019, 3:09 PM

source/blender/draw/modes/shaders/edit_mesh_overlay_mesh_analysis_vert.glsl
21	Hmmm.... This is unused for now... Should test.

It appears to be broken when using a subsurf modifier, both edit cage on and off have issues. In 2.79 it doesn't display any overlay colors in that case, which is ok as far as bringing back the functionality for 2.80. But we should avoid colors being on random faces as it is now.

Otherwise seems to be working well.

This revision now requires changes to proceed.Apr 19 2019, 3:09 PM

Don't show overlay when an modifiers are enabled in edit mode

Harbormaster completed remote builds in B3386: Diff 14827.Apr 19 2019, 4:31 PM

Brecht Van Lommel (brecht) accepted this revision.Apr 24 2019, 3:22 PM

Clément Foucault (fclem) added inline comments.Apr 24 2019, 3:51 PM

source/blender/draw/intern/draw_cache.h
62	Not sure how relevant this is since we won't support other object type.
source/blender/draw/intern/draw_cache_impl_mesh.c
1914	If data is per loop use loop_ prefix
1962	Use edit_mesh_analysis instead

naming conventions in draw manager

Harbormaster completed remote builds in B3424: Diff 14909.Apr 25 2019, 8:18 AM

Clément Foucault (fclem) accepted this revision.Apr 25 2019, 11:14 AM

This revision is now accepted and ready to land.Apr 25 2019, 11:14 AM

Closed by commit rB38a0896f1541: Overlay: Mesh Analysis (authored by Jeroen Bakker (jbakker)). · Explain WhyApr 25 2019, 11:28 AM

This revision was automatically updated to reflect the committed changes.

Overlay: 3D Printing
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 14827

source/blender/draw/CMakeLists.txt

source/blender/draw/intern/draw_cache.h

source/blender/draw/intern/draw_cache.c

source/blender/draw/intern/draw_cache_impl.h

source/blender/draw/intern/draw_cache_impl_mesh.c

source/blender/draw/modes/edit_mesh_mode.c

source/blender/draw/modes/shaders/edit_mesh_overlay_mesh_analysis_frag.glsl

source/blender/draw/modes/shaders/edit_mesh_overlay_mesh_analysis_vert.glsl

Overlay: 3D PrintingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14827

source/blender/draw/CMakeLists.txt

source/blender/draw/intern/draw_cache.h

source/blender/draw/intern/draw_cache.c

source/blender/draw/intern/draw_cache_impl.h

source/blender/draw/intern/draw_cache_impl_mesh.c

source/blender/draw/modes/edit_mesh_mode.c

source/blender/draw/modes/shaders/edit_mesh_overlay_mesh_analysis_frag.glsl

source/blender/draw/modes/shaders/edit_mesh_overlay_mesh_analysis_vert.glsl

Overlay: 3D Printing
ClosedPublic
Actions

Revision Contents
Changeset List