Add backdrop callback.
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Apr 19 2019, 6:52 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)
Brecht Van Lommel (brecht)

Commits

rBS8e861725dc9e: Space_node: Add draw backdrop callback.
rB8e861725dc9e: Space_node: Add draw backdrop callback.

Summary

Issue has come up here and here
changing the view matrix every time regardless if there
was a callback seemed unnecessarily expensive, added
ED_region_has_draw_cb to see if a region has a call
back of a specific type.

Currently 0,0 is in the lower left corer unsure what
would be better here, 0,0 in the lower left or in the
center of the region.

for easy testing the script from Stevo312 can be used just change the callback to BACKDROP

Diff Detail

Repository: rB Blender

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.Apr 19 2019, 6:52 PM

Harbormaster completed remote builds in B3388: Diff 14831.Apr 19 2019, 6:52 PM

Ray Molenkamp (LazyDodo) edited the summary of this revision. (Show Details)Apr 19 2019, 6:55 PM

Miguel Porces (cmporces) awarded a token.Apr 19 2019, 11:36 PM

Steven Munn (Stevo312) awarded a token.Apr 20 2019, 5:36 AM

Steven Munn (Stevo312) added a subscriber: Steven Munn (Stevo312).

Having REGION_DRAW_BACKDROP makes sense.

The ED_region_has_draw_cb function seems to be an unnecessary optimization.
AFAIK changing the view matrix is very cheap compared to the other stuff that is happening.
If you remove it, you can ignore the inline comments.

source/blender/editors/include/ED_space_api.h
71	missing name for the `int` parameter
source/blender/editors/space_api/spacetypes.c
268 ↗	(On Diff #14831)	why not return `bool`? What kind of `type`? Choose a more descriptive variable name?