Differential D4719
Bevel Tool: Add functionality for width-method Width and Depth, when 'Only Vertices' is selected. Authored by George Vogiatzis (Gvgeo) on Apr 22 2019, 10:49 AM.
Details
Bevel Tool:
v2 = BM_edge_other_vert(e->e, bv->v);
Diff Detail
Event TimelineComment Actions This looks good. Thanks for doing this. The solution for what to do about 'width' seems like the best approximate solution to a somewhat undefined problem. Please make the following minor changes:
Comment Actions Changes made.
Comment Actions Glad to hear. This patch was a mean, to pass my idea to you primarily. I did not double check it. Made change 4 to fix it. Normal could be added as an option, too. Could give better vertex bevel, or even edge bevel. Comment Actions Why did you move the weight transfer stuff for vertex_only down? It seems that it now moves it past the point where the BM_ELEM tags were needed and set/unset. Comment Actions I moved them, to avoid double if (vertex_only). But preferred to find center axis after the edges have completely calculated. But forgot this part. if (bp->dvert != NULL && bp->vertex_group != -1) {
weight = defvert_find_weight(bp->dvert + BM_elem_index_get(v), bp->vertex_group);
if (weight <= 0.0f) { <---------------- never true
BM_elem_flag_disable(v, BM_ELEM_TAG);
return NULL;
}
bv->offset *= weight;
}Bevel modifier call. static Mesh *applyModifier(ModifierData *md, const ModifierEvalContext *ctx, Mesh *mesh)
{
.
.
.
if (vertex_only) {
BM_ITER_MESH (v, &iter, bm, BM_VERTS_OF_MESH) {
if (!BM_vert_is_manifold(v)) {
continue;
}
if (bmd->lim_flags & MOD_BEVEL_WEIGHT) {
weight = BM_elem_float_data_get(&bm->vdata, v, CD_BWEIGHT);
if (weight == 0.0f) {
continue;
}
}
else if (vgroup != -1) {
weight = defvert_array_find_weight_safe(dvert, BM_elem_index_get(v), vgroup);
/* Check is against 0.5 rather than != 0.0 because cascaded bevel modifiers will
* interpolate weights for newly created vertices, and may cause unexpected "selection" */
if (weight < 0.5f) { <---------------- Will skip BM_elem_flag_enable. Without flag will not even reach bevel_vert_construct function.
continue;
}
}
BM_elem_flag_enable(v, BM_ELEM_TAG);
}
}
.
.
.
BM_mesh_bevel( );
.
.
.
}Bevel edit mode call void bmo_bevel_exec(BMesh *bm, BMOperator *op)
{
.
.
.
BM_mesh_bevel(bm,
offset,
offset_type,
seg,
profile,
vonly,
false,
clamp_overlap,
NULL, <----- Sends *dvert NULL
-1, <- and vertex_group -1
material,
loop_slide,
mark_seam,
mark_sharp,
harden_normals,
face_strength_mode,
miter_outer,
miter_inner,
spread,
smoothresh);
BMO_slot_buffer_from_enabled_hflag(bm, op, op->slots_out, "faces.out", BM_FACE, BM_ELEM_TAG);
BMO_slot_buffer_from_enabled_hflag(bm, op, op->slots_out, "edges.out", BM_EDGE, BM_ELEM_TAG);
BMO_slot_buffer_from_enabled_hflag(bm, op, op->slots_out, "verts.out", BM_VERT, BM_ELEM_TAG);
}
}Comment Actions This looks good now. I agree with you that the weight <=0 case cannot occur at that point in the code. |