Fix T63794: Duplicating an armature clears B-Bones' custom handle references
ClosedPublic
Actions

Authored by Tomoaki Kawada (yvt) on Apr 23 2019, 6:18 PM.

Details

Reviewers

Bastien Montagne (mont29)
Alexander Gavrilov (angavrilov)

Maniphest Tasks

T63794: Duplicating an armature clears B-Bones' custom handle references

Commits

rBS9e3246ce6e97: Fix T63794: duplicating an armature clears B-Bones' custom handle references.
rB9e3246ce6e97: Fix T63794: duplicating an armature clears B-Bones' custom handle references.

Summary

This patch fixes T63794 by updating duplicated bones' custom handle references to point the new armature's bones.

The problem occurs because B-Bones of a duplicated armature keep pointing the old armature's bones. The references are cleared upon entering Edit Mode because there are no matching EditBone for such bones, and find_ebone_link just returns NULL in such cases.

Diff Detail

Repository: rB Blender

Event Timeline

Tomoaki Kawada (yvt) created this revision.Apr 23 2019, 6:18 PM

Harbormaster completed remote builds in B3415: Diff 14886.Apr 23 2019, 6:18 PM

Tomoaki Kawada (yvt) edited the summary of this revision. (Show Details)Apr 23 2019, 6:19 PM

Brecht Van Lommel (brecht) added reviewers: Bastien Montagne (mont29), Alexander Gavrilov (angavrilov).Apr 23 2019, 6:20 PM

Tomoaki Kawada (yvt) edited the summary of this revision. (Show Details)Apr 23 2019, 6:27 PM

Looks ok overall, but I have some performance concerns.

source/blender/blenkernel/intern/armature.c
177	Maybe it's better to use BKE_armature_bone_from_name_map to create a hash table for lookup? In a big rig with many B-Bones this is effectively quadratic complexity, and this copying code is used internally by depsgraph for copy-on-write.