Page MenuHome
Differential D4733

Fix T63841: armature with X-axis mirror does not mirror bbone scale
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 24 2019, 3:46 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Alexander Gavrilov (angavrilov)
Maniphest Tasks
T63841: X-axis mirror do not scale corresponding bone with single bbone scale
Commits
rBS5d9d32fd1fa3: Fix T63841: armature with X-axis mirror does not mirror bbone scale
rB5d9d32fd1fa3: Fix T63841: armature with X-axis mirror does not mirror bbone scale

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Apr 24 2019, 3:46 PM
Harbormaster completed remote builds in B3422: Diff 14900.Apr 24 2019, 3:46 PM
Harbormaster completed remote builds in B3422: Diff 14900.
Philipp Oeser (lichtwerk) added a comment.Apr 24 2019, 3:49 PM

note: somewhat related situation was T57096 / rBe6adf9ac9a32

Brecht Van Lommel (brecht) accepted this revision.Apr 24 2019, 5:23 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/transform/transform_conversions.c
1337

This is going to give a compiler warning about arm being possibly used uninitialized. Can be solved like this:

else {
  BLI_assert(tc->poseobj != NULL);
  arm = tc->poseobj->data;
}
This revision is now accepted and ready to land.Apr 24 2019, 5:23 PM
Closed by commit rB5d9d32fd1fa3: Fix T63841: armature with X-axis mirror does not mirror bbone scale (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 24 2019, 10:46 PM
This revision was automatically updated to reflect the committed changes.
Alexander Gavrilov (angavrilov) mentioned this in T64091: Crash when changing BBone scale in pose mode..May 11 2019, 3:53 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
10 lines
17 lines

Diff 14905

View Options

source/blender/editors/transform/transform_conversions.c

Loading...
View Options

source/blender/editors/transform/transform_generics.c

Loading...