Page MenuHome

Evaluate animdata before rendering scene seqbase
ClosedPublic

Authored by Richard Antalik (ISS) on Apr 29 2019, 2:38 AM.

Diff Detail

Repository
rB Blender

Event Timeline

Harbormaster completed remote builds in B3448: Diff 14969.
  • Fix missing offset when evaluating scene strip animdata
source/blender/blenkernel/intern/sequencer.c
3668

Maybe I should use BKE_animsys_evaluate_all_animation here?

Not sure if there is maybe even some newer way, that is more preferable.

Brecht Van Lommel (brecht) requested changes to this revision.Apr 30 2019, 6:13 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenkernel/intern/sequencer.c
3667

This function is used for metastrips, in which case seq->scene would be NULL and this code shouldn't run?

3668

I guess BKE_animsys_evaluate_all_animation would be more correct, as the scene strips may be using animated datablocks.

I'm not sure if there's a better way for this currently. Ideally the sequencer and compositor would better integrate into the dependency graph, but manually updating animation is how it works for now.

This revision now requires changes to proceed.Apr 30 2019, 6:13 PM
Richard Antalik (ISS) marked 2 inline comments as done.

resolve inlines

This revision is now accepted and ready to land.May 1 2019, 3:24 PM
This revision was automatically updated to reflect the committed changes.