Page MenuHome
Differential D4759

A.N.T Landscape add-on broken after psutil API change
ClosedPublic
Actions

Authored by Predrag Ivanović (pedja) on Apr 29 2019, 2:43 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBA89568c1a42eb: Fix T63982: A.N.T. Landscape add-on broken after psutil API change
Summary

Patch for bug https://developer.blender.org/T63982

Diff Detail

Event Timeline

Predrag Ivanović (pedja) created this revision.Apr 29 2019, 2:43 PM
Jacques Lucke (JacquesLucke) added inline comments.Apr 29 2019, 2:51 PM
ant_landscape/stats.py
28

Code Style: There are missing spaces.

Also, better use something like hasattr(self.process, "get_cpu_time"). This should work as well, right?
Additionally it would be nice to put a comment there to explain why this check is necessary.

Can you get the current version from psutil? Maybe then the check could be something like if psutil.version < ....

Predrag Ivanović (pedja) added inline comments.Apr 29 2019, 5:02 PM
ant_landscape/stats.py
28

Also, better use something like hasattr(self.process, "get_cpu_time"). This should work as well, right?

If I am reading Python docs correctly, yes.
Since it returns true/false, no need for 'callable' then, correct?

Can you get the current version from psutil? Maybe then the check could be something like if psutil.version < ....

You can, but I can't figure out when the change happened.
So checking attribute name looks like a more robust solution?

Predrag Ivanović (pedja) updated this revision to Diff 14980.Apr 29 2019, 5:59 PM

Update based on code review:

  • Add comment to explain the change
  • Use hasattr() instead of getattr()
  • Hopefully fix code style issues
Jacques Lucke (JacquesLucke) accepted this revision.Apr 29 2019, 6:14 PM

Good, will merge it tomorrow.

This revision is now accepted and ready to land.Apr 29 2019, 6:14 PM
Ray Molenkamp (LazyDodo) added a subscriber: Ray Molenkamp (LazyDodo).Apr 29 2019, 6:15 PM
Ray Molenkamp (LazyDodo) added inline comments.
ant_landscape/stats.py
30

Typo get_cpu_time vs get_cpu_times ?

Jacques Lucke (JacquesLucke) added a comment.Apr 29 2019, 6:19 PM

Good catch..... Will fix that when merging.

Predrag Ivanović (pedja) updated this revision to Diff 14981.Apr 29 2019, 6:24 PM

Fix typo in attribute name

Jacques Lucke (JacquesLucke) added a comment.Apr 30 2019, 2:03 PM

Just for reference, the API was changed in version 2.0.
So this bug exists for more than 5 years^^

https://github.com/giampaolo/psutil/blob/master/HISTORY.rst#200

Closed by commit rBA89568c1a42eb: Fix T63982: A.N.T. Landscape add-on broken after psutil API change (authored by Predrag Ivanović (pedja), committed by Jacques Lucke (JacquesLucke)). · Explain WhyApr 30 2019, 2:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
ant_landscape/
12 lines

Diff 14981

View Options

ant_landscape/stats.py

Loading...