Page MenuHome
Differential D475

Fix T39808: UV Map node does not account for displacement
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Apr 20 2014, 7:01 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T39808: UV Map node not fully working
Commits
rBS83988b6cdd18: Fix new Cycles UV Map node not working correct for bump mapping.
rC897c4fa425a9: Fix new Cycles UV Map node not working correct for bump mapping.
rBAC83988b6cdd18: Fix new Cycles UV Map node not working correct for bump mapping.
rB83988b6cdd18: Fix new Cycles UV Map node not working correct for bump mapping.

Diff Detail

Event Timeline

Kévin Dietrich (kevindietrich) added a comment.Apr 20 2014, 7:06 PM

The patch looks weird here, attaching :

uvmap.diff1 KBDownload

Brecht Van Lommel (brecht) accepted this revision.Apr 21 2014, 1:17 PM

Looks good to me, will commit.

The patch has some mixs of tabs and spaces, and trailing spaces that should avoided. Just a reminder for future patches.

Brecht Van Lommel (brecht) closed this revision.Apr 21 2014, 2:45 PM

Closed by commit rB83988b6cdd18 (authored by @Kévin Dietrich (kevindietrich), committed by @Brecht Van Lommel (brecht)).

Kévin Dietrich (kevindietrich) added a comment.Apr 21 2014, 3:16 PM

Thanks for the commit!

So that's why it was looking weird. I'll try and be more careful about spaces and tabs for the future.

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
shaders/
23 lines
render/
16 lines

Diff 1508

View Options

intern/cycles/kernel/shaders/node_uv_map.osl

Loading...
View Options

intern/cycles/render/nodes.cpp

Loading...