Remove Doubles -> Merge by Distance
ClosedPublic
Actions

Authored by William Reynish (billreynish) on Apr 30 2019, 9:12 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Pablo Vazquez (pablovazquez)
Campbell Barton (campbellbarton)

Group Reviewers

User Interface

Summary

In accordance with T56648, this changes the name of the Remove Doubles operator to Merge by Distance. This patch only changes the user-visible name, not the Python API.

Why the name change?

The current Remove Doubles operator name is not clear: 'Doubles' implies exactly two items, even though it works in an arbitrary number of vertices. 'Remove' is also misleading - really it's just performing a merge operation.

Since this operator is really just a special kind of Merge that takes distance into account, the name can reflect that.

Alternative options: Distance Merge, Proximity Merge

Diff Detail

Event Timeline

William Reynish (billreynish) created this revision.Apr 30 2019, 9:12 PM

Benjamin Sauder (kioku) awarded a token.May 1 2019, 3:18 PM

Brecht Van Lommel (brecht) accepted this revision as: Brecht Van Lommel (brecht).May 1 2019, 3:24 PM

This revision is now accepted and ready to land.May 1 2019, 3:24 PM

Looks good to me.

Only request is if you can add it to the Merge (Alt+M) menu? Having some merge options available in one menu and some in others can lead to confusion.

+1 to add to merge menu (note that this would become a Menu instead of an expanded operator internally, since remove-doubles wouldn't be the same operator as merge).

Campbell Barton (campbellbarton) accepted this revision.May 2 2019, 12:11 PM

Update:

Updated to apply cleanly to master
Added Merge by Distance into Edit Mode Merge sub-menu

Antonio Vazquez (antoniov) awarded a token.May 2 2019, 1:34 PM

Use shortened title 'By Distance' from inside the Merge menu. The other items also don't include the word Merge in this context.

Good! Just one comment in the label of the menu.

Also, will the keymap change be in a follow up commit? To make Alt+M call VIEW3D_MT_edit_mesh_merge instead of the operator MESH_OT_merge.

release/scripts/startup/bl_ui/space_view3d.py
19	Shouldn't it be called `Merge`?

Commited w/ minor edits rBa914765221fb370244998c805f0750c2370fbfe4

Use operator_enum (needed since first two options depend on active vertex)
Use in default keymap.
Renamed "Delete" -> "Merge".

Campbell Barton (campbellbarton) accepted this revision.May 2 2019, 1:59 PM

Campbell Barton (campbellbarton) closed this revision.

Deen (Bit) awarded a token.May 3 2019, 3:35 PM

Merge (what?) by distance. The name is not that much better than remove double, it would make more sense if found under the verteices menu, but in a general clean up menu, that the user reaches to fix a problem/clean up a mess the options would be better if stated the solution or the problem related. Like "remove doubles" a double vertex as two vertex occupying the same space is the unwanted trouble...
This is my opinion...