Cleanup: Use generics properties for arrow keys navigation(walk_select)
ClosedPublic
Actions

Authored by Valentin (Poulpator) on May 1 2019, 12:41 AM.

Details

Reviewers

Julian Eisel (Severin)

Maniphest Tasks

T63992: Outliner: Keyboard navigation

Commits

rB7b8db971d42f: Cleanup: Use generics properties for arrow keys navigation (walk-select)

Summary

This patch refactor arrow keys navigation to move properties and enum to generic ED_select_utils.h and property to WM_operator_properties_select_walk_direction()

No functional change

Diff Detail

Event Timeline

Valentin (Poulpator) created this revision.May 1 2019, 12:41 AM

Harbormaster completed remote builds in B3467: Diff 15020.May 1 2019, 12:41 AM

Valentin (Poulpator) retitled this revision from refactor: arrow keys navigation(walk_select), move properties and enum to generic ED_select_utils.h and property to WM_operator_properties_select_walk_direction() to refactor: arrow keys navigation(walk_select).May 1 2019, 12:46 AM

Valentin (Poulpator) edited the summary of this revision. (Show Details)

Valentin (Poulpator) added reviewers: Campbell Barton (campbellbarton), Julian Eisel (Severin).

William Reynish (billreynish) added a reviewer: Dalai Felinto (dfelinto).May 1 2019, 9:07 AM

Think this is fine, although better wait until it's used somewhere else than file browser (outliner most likely). Also, might make sense to add UI_ prefix, so UI_SELECT_WALK_FOO to make clear this is UI only.

Julian Eisel (Severin) accepted this revision.May 3 2019, 10:59 PM

This revision is now accepted and ready to land.May 3 2019, 10:59 PM

Nice. I’m guessing this will make it easier to re-use this for other places such as the Outliner?

William Reynish (billreynish) awarded a token.May 5 2019, 2:08 PM

Nathan Craddock (natecraddock) added a subscriber: Nathan Craddock (natecraddock).Jun 2 2019, 4:25 AM

Updated the diff to master
Addressed comment

I guess it could apply for code quality day

Valentin (Poulpator) retitled this revision from refactor: arrow keys navigation(walk_select) to Cleanup: Use generics properties for arrow keys navigation(walk_select).Feb 7 2020, 10:48 PM

Valentin (Poulpator) edited the summary of this revision. (Show Details)

Just tested this. I don't see any reason why it shouldn't be committed.

Nathan Craddock (natecraddock) awarded a token.Feb 27 2020, 3:17 AM

Dalai Felinto (dfelinto) removed reviewers: Campbell Barton (campbellbarton), Dalai Felinto (dfelinto).Mar 2 2020, 3:29 PM

Dalai Felinto (dfelinto) added subscribers: Dalai Felinto (dfelinto), Campbell Barton (campbellbarton).

Closed by commit rB7b8db971d42f: Cleanup: Use generics properties for arrow keys navigation (walk-select) (authored by Valentin Fuhrer (valentin), committed by Julian Eisel (Severin)). · Explain WhyMar 2 2020, 4:08 PM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rB7b8db971d42f: Cleanup: Use generics properties for arrow keys navigation (walk-select).