Page MenuHome
Differential D4774

Alembic: integrate cache file into the dependency graph
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on May 1 2019, 2:29 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T62720: Importing Alembic Mesh Causes Blender To Crash As Well As Alembic Sequences/Playback of Alembic sequences does not work
T63276: Crash when deleting a parent object after Alembic import
Commits
rBS89826e0a0d8a: Alembic: integrate cache file into the dependency graph
rB89826e0a0d8a: Alembic: integrate cache file into the dependency graph
Summary
  • The cache file datablock is now evaluated as part of the dependency graph, creating/freeing the Alembic file handle matching the current frame. Modifiers and constraints depend on this evaluation.
  • Cache file handles and readers now only exist on COW datablocks, never the original ones.
  • Object data paths are flushed back to the original for the user interface.
  • The cache file keeps a list of all readers associated with its handle, and automatically frees them when the handle is freed. This kind of sharing of data across datablocks is weak but we have no better mechanism for it.

Fix T62720: Alembic sequences not working and crashing

Diff Detail

Repository
rB Blender
Branch
cache-deps (branched from master)
Build Status
Buildable 3472
Build 3472: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) created this revision.May 1 2019, 2:29 PM
Harbormaster completed remote builds in B3472: Diff 15026.May 1 2019, 2:29 PM
Harbormaster completed remote builds in B3472: Diff 15026.
Brecht Van Lommel (brecht) edited the summary of this revision. (Show Details)May 1 2019, 2:30 PM
Brecht Van Lommel (brecht) added a task: T62720: Importing Alembic Mesh Causes Blender To Crash As Well As Alembic Sequences/Playback of Alembic sequences does not work.
Sergey Sharybin (sergey) accepted this revision.May 1 2019, 3:10 PM

From quick reading seems fine to me.

This revision is now accepted and ready to land.May 1 2019, 3:10 PM
Closed by commit rB89826e0a0d8a: Alembic: integrate cache file into the dependency graph (authored by Brecht Van Lommel (brecht)). · Explain WhyMay 1 2019, 4:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
alembic/
intern/
3 lines
7 lines
blenkernel/
27 lines
intern/
247 lines
24 lines
9 lines
blenloader/
intern/
5 lines
depsgraph/
intern/
builder/
8 lines
11 lines
editors/
interface/
5 lines
io/
14 lines
makesdna/
12 lines
5 lines
5 lines
makesrna/
intern/
38 lines
18 lines
15 lines
modifiers/
intern/
28 lines

Diff 15026

View Options

source/blender/alembic/intern/abc_object.cc

Loading...
View Options

source/blender/alembic/intern/alembic_capi.cc

Loading...
View Options

source/blender/blenkernel/BKE_cachefile.h

Loading...
View Options

source/blender/blenkernel/intern/cachefile.c

Loading...
View Options

source/blender/blenkernel/intern/constraint.c

Loading...
View Options

source/blender/blenkernel/intern/scene.c

Loading...
View Options

source/blender/blenloader/intern/readfile.c

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Loading...
View Options

source/blender/editors/interface/interface_templates.c

Loading...
View Options

source/blender/editors/io/io_cache.c

Loading...
View Options

source/blender/makesdna/DNA_cachefile_types.h

Loading...
View Options

source/blender/makesdna/DNA_constraint_types.h

Loading...
View Options

source/blender/makesdna/DNA_modifier_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_cachefile.c

Loading...
View Options

source/blender/makesrna/intern/rna_constraint.c

Loading...
View Options

source/blender/makesrna/intern/rna_modifier.c

Loading...
View Options

source/blender/modifiers/intern/MOD_meshsequencecache.c

Loading...