Differential D4787
Draw Border Around Icons Authored by Jeroen Bakker (jbakker) on May 3 2019, 10:15 AM.
Details When loading the monochrome icons blender will generate a border around them. This border will enhance the contrast when doing themes icons. Icons 16x16:  Icons 32x32:  This is what it might look like when used in a light theme. 
Diff Detail
Event TimelineComment Actions To be clear, this must still become a theme setting where you can choose the outline intensity. It would be enabled by default in Blender Light, but not in Blender Dark. Comment Actions A limitation of this is when it is done. With my dynamic experiments the outline was added at the time the icon was drawn, so it could act differently depending on the icon colour at that time. So a light icon could get an outline and a nearby dark icon might not. This method will necessarily cause some constraint on what themes can do. When we first added these monochrome icons I wished we would have done it right and allowed uibut to have icon colour overrides that were used at the time of drawing, rather than broadly recolouring as we are for outliner and now Properties. We now removing the big advantage they had, being able to output them at any colour at will. Comment Actions @Harley Acheson (harley) thanks for your feedback. This task is the minimum that is needed for Blender 2.80; mid May we need to finalize this and there are still a lot of other stuff that needs to be completed. Comment Actions I think I was just wrong about this approach happening too early and broadly. I think, in practice, it will work out wonderfully. That is because I think it will be enabled in more circumstances than we might initially think. Enabling dark outlines when using the dark theme might not seem to make sense, but I think that will happen. A dark outline does no harm for a light icon on a dark background, but it does help within that same theme when we have icons on less dark colors (like viewport shading icons). So I think in the end my initial worry is just without merit. Yes, I never wanted uiBut (or operators) to have wide-open RGBA color overrides as that would end up a mess pretty quickly. But instead to just use theme Color ids. What I thought ideal is if uiBut started with an icon_color of TH_UNDEFINED and would therefore, by default, act as it does now and use TH_TEXT for the icon color. But if set then widget_draw_icon() would use this color instead. That way the Outliner could draw the same icons in the same colors it does now, using the same theme preferences, but just not in a way that colors those icons for all uses outside of the Outliner. Comment Actions @Brecht Van Lommel (brecht) I added an option in the theme for when the border should be drawn. In stead of a boolean I used an enum so it is more future proof when adding other selections. If you prefer a boolean, please lemme know. I would expect that in the future we also want to theme the color of the border and perhaps the sharpness of the border to create a shadow effect. Comment Actions Currently it looks like this:  Personally I find the effect a little on the strong side. Is the Outline color/opacity hardcoded to be black with 100% alpha? In any case, now that it's a theme setting we can keep it off for the default theme. Comment Actions I don't think we need to give an outline to all icons. Only do it for themed icons since it doesn't work well for all icons, and once we expose that possibility we are stuck dealing with the associated problems at some point. Instead I would like to see a float 0..1 factor for the outline intensity, going from fully transparent to opaque black. Probably the default for Blender light can be a bit lower than 1.
Comment Actions
This patch already does that - in the theme you can set it to only apply to the 'themed' icons. Comment Actions Yes, and there should be no preference to do it for all icons. Because if we add functionality we should support it properly, and it doesn't work well now. Comment Actions Just to be clear, if we have an 0..1 slider I don't think we need the enum at all. It can just do nothing when the value is 0.0. Comment Actions
Comment Actions Looks promising. Maybe those outlines should be always enabled, even for the dark theme. Comment Actions Not sure if this is waiting for review or not, but marking as request changes since the boolean should become a 0..1 slider. | ||||||||||