Page MenuHome
Differential D478

Fix T39781: Autosmooth feature: erroneously showing hidden vertices' normals too when in "vertex per face" display
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Apr 21 2014, 7:44 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T39781: Autosmooth feature: erroneously showing hidden vertices' normals too when in "vertex per face" display
Commits
rBS70fdcebb93f0: Fix T39781: Autosmooth feature: erroneously showing hidden vertices' normals…
rBAC70fdcebb93f0: Fix T39781: Autosmooth feature: erroneously showing hidden vertices' normals…
rB70fdcebb93f0: Fix T39781: Autosmooth feature: erroneously showing hidden vertices' normals…
rB60b015d1fc10: Update ffmpeg in install_deps.sh to 2.1.4.
rBdda567866924: Cleanup in modifier stack evaluation: deduplicate final tessellation handling…
Summary

So, turned out after all we need a foreachmapped helper for loops as well... :/

CDDM and EBDM were reasonably simple, but I faought hours with CCGDM (subsurf) to find only a
bad working solution (commented out in this patch). So I fallback to a code similar to CDDM one.
Probably not nice for performances, but loops and subsurf are not matching well...

Diff Detail

Event Timeline

Campbell Barton (campbellbarton) added a comment.Apr 22 2014, 10:32 AM

Checking if (flag & DM_FOREACH_USE_NORMAL) { seems a bit strange, shouldn't this be a check inline? rather then 2 codepaths just for normals?

source/blender/blenkernel/intern/cdderivedmesh.c
1723

for sake of completeness shouldn't it else { and loop over loops still?

source/blender/blenkernel/intern/editderivedmesh.c
414

Same as above

Bastien Montagne (mont29) updated this revision to Unknown Object (????).Apr 23 2014, 3:07 PM

Updated to not depend on USE_NORMAL!

Bastien Montagne (mont29) added a comment.Apr 23 2014, 3:08 PM

Yuck, sorry, will update patch again :/

Bastien Montagne (mont29) closed this revision.Apr 23 2014, 3:08 PM

Closed by commit rBdda567866924 (authored by @Bastien Montagne (mont29)).

Bastien Montagne (mont29) reopened this revision.Apr 23 2014, 3:11 PM

grmlll…

Bastien Montagne (mont29) updated this revision to Unknown Object (????).Apr 23 2014, 3:12 PM

real updated patch...

Campbell Barton (campbellbarton) added a comment.Apr 23 2014, 3:16 PM

LGTM.

picky editderivedmesh.c has some odd WS changes

source/blender/blenkernel/intern/subsurf_ccg.c
1567

prefer not to commit this really large chunk if its not used. For archival purposes it can remain in this diff?

Bastien Montagne (mont29) closed this revision.Apr 23 2014, 3:27 PM

Closed by commit rB70fdcebb93f0 (authored by @Bastien Montagne (mont29)).

Bastien Montagne (mont29) mentioned this in rBS70fdcebb93f0: Fix T39781: Autosmooth feature: erroneously showing hidden vertices' normals….Nov 20 2014, 9:32 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
11 lines
intern/
30 lines
34 lines
30 lines
editors/
space_view3d/
61 lines

Diff 1533

View Options

source/blender/blenkernel/BKE_DerivedMesh.h

Loading...
View Options

source/blender/blenkernel/intern/cdderivedmesh.c

Loading...
View Options

source/blender/blenkernel/intern/editderivedmesh.c

Loading...
View Options

source/blender/blenkernel/intern/subsurf_ccg.c

Loading...
View Options

source/blender/editors/space_view3d/drawobject.c

Loading...