Unit test for BLI_path_util
Needs ReviewPublic
Actions

Authored by Habib Gahbiche (zazizizou) on May 5 2019, 5:43 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Summary

Added unit test:

BLI_path_make_safe
updated link in function documentation

Test for BLI_path_make_safe is failing based on expected behavior from function description (and not implementation).

The reason for that is slashes and backslashes are not detected and/or replaced correctly. I'm working on a fix, though I'm still not sure why slashes are not handled properly.

Diff Detail

Repository

rB Blender

Branch

test_make_safe (branched from master)

Build Status

Buildable 3513
Build 3513: arc lint + arc unit

Event Timeline

Habib Gahbiche (zazizizou) created this revision.May 5 2019, 5:43 PM

Harbormaster completed remote builds in B3512: Diff 15136.May 5 2019, 5:43 PM

Habib Gahbiche (zazizizou) updated this revision to Diff 15138.May 5 2019, 5:44 PM

Harbormaster completed remote builds in B3513: Diff 15138.May 5 2019, 5:44 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenlib/

intern/

path_util.c

2 lines

tests/

gtests/

blenlib/

BLI_path_util_test.cc

45 lines

Diff 15138

View Options

source/blender/blenlib/intern/path_util.c