Curve extrude operator
AbandonedPublic
Actions

Authored by Matthew (Loading_M_) on May 6 2019, 8:31 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Sergey Sharybin (sergey)
Bastien Montagne (mont29)

Maniphest Tasks

T47169: Improve Curve extrude

Summary

Fixes the extrude operator to be able to extrude the middle of a curve in a more intuitive way. The extrude operator will still extend the end, but also allows for a curve to be extended from the middle of a curve.

Diff Detail

Event Timeline

Matthew (Loading_M_) created this revision.May 6 2019, 8:31 PM

Matthew (Loading_M_) added a task: T47169: Improve Curve extrude.

Matthew (Loading_M_) mentioned this in T47169: Improve Curve extrude.May 6 2019, 8:35 PM

Matthew (Loading_M_) edited reviewers, added: Bastien Montagne (mont29); removed: Bastian Leonhardt Strube (bastianls).May 6 2019, 9:07 PM

Removed unneeded printf statements.

Duarte Farrajota Ramos (duarteframos) awarded a token.May 7 2019, 12:16 AM

Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).

Format w/ clang-format

Harbormaster completed remote builds in B3520: Diff 15165.May 7 2019, 6:06 AM

Checked this patch, extruding from a single vertex crashes.

Otherwise works well.

This revision now requires changes to proceed.May 7 2019, 6:09 AM

I can't reproduce any crashing on Linux Mint. Can you give me some more details, like which platform you tested the patch on?

Fixed the crashing issue with a single vertex. It would appear that C is not short circuiting Boolean expressions (or executing them in reverse) that are part of a return statement. I also fixed a minor issue where a single vertex in a cyclical curve couldn't be extruded.

Already solved by rB38685b5a3976: Edit Curve: Improve Curve extrude

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

curve/

editcurve.c

385 lines

Diff 15213

View Options

source/blender/editors/curve/editcurve.c

Curve extrude operatorAbandonedPublicActions