Page MenuHome
Differential D4813

Rename Balls to Spheres.
ClosedPublic
Actions

Authored by George Vogiatzis (Gvgeo) on May 6 2019, 9:26 PM.

Details

Reviewers
Pablo Vazquez (pablovazquez)
William Reynish (billreynish)
Clément Foucault (fclem)
Campbell Barton (campbellbarton)
Summary

Must protect people from their dirty minds.

  1. Rename Ball/Balls to Spheres, in user interface and code.
  2. Some minor wording changes to UI for for consistency

Diff Detail

Event Timeline

George Vogiatzis (Gvgeo) created this revision.May 6 2019, 9:26 PM
William Reynish (billreynish) accepted this revision.May 6 2019, 11:05 PM
This revision is now accepted and ready to land.May 6 2019, 11:05 PM
Roger B (rboxman) added a subscriber: Roger B (rboxman).May 6 2019, 11:41 PM

Probably needs a style guide change as well. Just in these messages there's "Look Dev", "LookDev", and "look development"

George Vogiatzis (Gvgeo) updated this revision to Diff 15166.May 7 2019, 7:08 AM
In D4813#109902, @Roger B (rboxman) wrote:

Probably needs a style guide change as well. Just in these messages there's "Look Dev", "LookDev", and "look development"

George Vogiatzis (Gvgeo) planned changes to this revision.May 7 2019, 7:11 AM

Will look to change the api to shperes too, for consistency.

George Vogiatzis (Gvgeo) updated this revision to Diff 15168.May 7 2019, 8:55 AM
George Vogiatzis (Gvgeo) edited the summary of this revision. (Show Details)
George Vogiatzis (Gvgeo) added a reviewer: Clément Foucault (fclem).

Rename Ball to Spheres for consistency. In API and code too.

This revision is now accepted and ready to land.May 7 2019, 8:55 AM
William Reynish (billreynish) added a comment.May 7 2019, 10:43 AM

I think we should also rename Look Dev Preview to Look Dev Spheres for consistency.

George Vogiatzis (Gvgeo) updated this revision to Diff 15176.May 7 2019, 10:51 AM
George Vogiatzis (Gvgeo) edited the summary of this revision. (Show Details)
In D4813#110000, @William Reynish (billreynish) wrote:

I think we should also rename Look Dev Preview to Look Dev Spheres for consistency.

William Reynish (billreynish) accepted this revision.May 7 2019, 10:54 AM
Campbell Barton (campbellbarton) mentioned this in rB3f37787c804a: UI: rename Look Dev 'Ball' to 'Sphere'.May 9 2019, 1:46 PM
Campbell Barton (campbellbarton) accepted this revision.May 9 2019, 1:47 PM
Campbell Barton (campbellbarton) closed this revision.

Thanks, committed rB3f37787c804a2eab3fd5ac26fb24772ef52c9b60

(renamed lookdev_spheres_size -> lookdev_sphere_size)

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
2 lines
source/
blender/
blenloader/
intern/
4 lines
draw/
engines/
eevee/
2 lines
38 lines
2 lines
makesdna/
2 lines
makesrna/
intern/
2 lines
6 lines

Diff 15176

View Options

release/scripts/startup/bl_ui/space_userpref.py

Loading...
View Options

source/blender/blenloader/intern/versioning_userdef.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_effects.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_lookdev.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_private.h

Loading...
View Options

source/blender/makesdna/DNA_userdef_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...
View Options

source/blender/makesrna/intern/rna_userdef.c

Loading...