Differential D4821

Animation editor scrollbars
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on May 7 2019, 5:54 PM.

Tags

None

Subscribers

William Reynish (billreynish)

Details

Reviewers

William Reynish (billreynish)
Brecht Van Lommel (brecht)

Commits

rBS3b9813fe5049: UI: Move scrollbars to the right in animation editors
rB3b9813fe5049: UI: Move scrollbars to the right in animation editors

Summary

Diff Detail

Repository

Branch

scrollbars (branched from master)

Build Status

Buildable 3534
Build 3534: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.May 7 2019, 5:54 PM

Harbormaster completed remote builds in B3534: Diff 15194.May 7 2019, 5:54 PM

rename V2D_SCROLL_SCALE_* to V2D_SCROLL_*_HANDLES
rename V2D_SCROLL_WIDTH_TEXT and V2D_SCROLL_HEIGHT_TEXT
make number position independent of scrollbar position
move scrollbar to the right

Harbormaster completed remote builds in B3540: Diff 15204.May 8 2019, 12:22 PM

update comment

Harbormaster completed remote builds in B3541: Diff 15205.May 8 2019, 12:24 PM

Jacques Lucke (JacquesLucke) added a reviewer: William Reynish (billreynish).May 8 2019, 12:24 PM

Jacques Lucke (JacquesLucke) retitled this revision from Animation editor scrollbars [WIP] to Animation editor scrollbars.

Tested. Seems to work well.

Looks like this currently:

Currently they don't fade away based on distance, but I think that might be the best thing. this makes it so you can always judge where in the animation you are, even when the cursor is somewhere else. That is probably the right thing here.

This revision is now accepted and ready to land.May 8 2019, 1:48 PM

Jacques Lucke (JacquesLucke) added a reviewer: Brecht Van Lommel (brecht).May 8 2019, 1:52 PM

fix small alignment issues of scroll handles

Harbormaster completed remote builds in B3543: Diff 15210.May 8 2019, 2:43 PM

William Reynish (billreynish) accepted this revision.May 8 2019, 2:57 PM

Brecht Van Lommel (brecht) accepted this revision.May 8 2019, 3:05 PM

Closed by commit rB3b9813fe5049: UI: Move scrollbars to the right in animation editors (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMay 8 2019, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_clip/

13 lines

space_graph/

14 lines

space_sequencer/

sequencer_draw.c

10 lines

space_sequencer.c

3 lines

Diff 15194

source/blender/editors/space_clip/space_clip.c

Loading...

source/blender/editors/space_graph/space_graph.c

Loading...

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...

source/blender/editors/space_sequencer/space_sequencer.c

Loading...