Workbench: Viewport AA Preferences
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on May 8 2019, 3:42 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Clément Foucault (fclem)

Maniphest Tasks

T64132: No viewport anti-aliasing in the shaded mode in the latest 2.8 builds from blender-2.80.0-git.b331515d2e47-windows64 (May 03) onward

Commits

rBS0764cfe3deea: Workbench: Viewport AA Preferences
rB0764cfe3deea: Workbench: Viewport AA Preferences

Summary

In recent changes the viewport_quality setting was not working what
users expected. This change will separate the anti-aliasing method that
is being used.

We now have three settings:

scene.display.render_aa: Will be used during Render Image.
scene.display.viewport_aa: Will be used during Viewport Render Image.
userpref.viewport_aa: Will be used in the 3d view.

The viewport_quality setting has been replaced by the viewport_aa
setting as it was the only thing in currently controlled.

Diff Detail

Repository

rB Blender

Branch

T64132 (branched from master)

Build Status

Buildable 3553
Build 3553: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.May 8 2019, 3:42 PM

Harbormaster completed remote builds in B3544: Diff 15212.May 8 2019, 3:42 PM

Jeroen Bakker (jbakker) added reviewers: Brecht Van Lommel (brecht), Clément Foucault (fclem).May 8 2019, 3:42 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Brecht Van Lommel (brecht) accepted this revision.May 8 2019, 3:50 PM

Jeroen Bakker (jbakker) removed 1 blocking reviewer(s): Clément Foucault (fclem).May 9 2019, 2:28 PM

This revision is now accepted and ready to land.May 9 2019, 2:28 PM

Silenced compiler warnings

Harbormaster completed remote builds in B3553: Diff 15231.May 9 2019, 2:44 PM

Closed by commit rB0764cfe3deea: Workbench: Viewport AA Preferences (authored by Jeroen Bakker (jbakker)). · Explain WhyMay 9 2019, 2:46 PM

This revision was automatically updated to reflect the committed changes.

Daniel Paul (DaPaulus) added a subscriber: Daniel Paul (DaPaulus).May 10 2019, 12:56 PM

At the moment, Render AA from workbench isn't applied to Render Viewport Image and Render Viewport Animation.

What is the difference between Render AA and EEVEE samples?

When rendering with F12 EEVEE uses samples, while rendering viewport animation render AA is used,
at least this was the behavior some days ago. Render AA also seems faster.

Would it be possible to choose if normal AA or Samples are used? (For F12 and Viewport rendering)

Daniel Paul (DaPaulus) awarded a token.May 10 2019, 1:02 PM