Details

Reviewers

Campbell Barton (campbellbarton)
Clément Foucault (fclem)

Maniphest Tasks

T54686: Multi-Object-Mode: EditMesh GL selection objects don't occlude eachother

Summary

Fix T54686.

The solution is to draw all edited objects with an initial offset index for each object.
Thus there are no repeated indexes and it is possible to identify the base by ranges of indices.

draw_object_select_id has been moved from view_3d_inter.h / drawobject.c to draw_manager.c.
Circle Select and similar were not affected and therefore still ignore occlusion.

We can optimize a bit more on mixed selections by drawing all the selection elements within the same range of indices. But that may be for another patch.

Diff Detail

Repository

rB Blender

Branch

T (branched from master)

Build Status

Buildable 3600
Build 3600: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.May 15 2019, 3:18 PM

Harbormaster completed remote builds in B3594: Diff 15351.May 15 2019, 3:18 PM

fix bad ViewContext pointer.

Harbormaster completed remote builds in B3595: Diff 15352.May 15 2019, 3:43 PM

scene -> scene_eval

Harbormaster completed remote builds in B3596: Diff 15353.May 15 2019, 4:14 PM

Fix use evaluated object to select
Fix base_index return

Harbormaster completed remote builds in B3598: Diff 15357.May 15 2019, 7:27 PM

Remnant from hack to refresh selection buffer needed to be removed:
(ED_view3d_viewcontext_init_object was setting V3D_INVALID_BACKBUF on each call)
causing border select to generate all objects selection id's - for each object.

Also removed unused arguments.

Harbormaster completed remote builds in B3599: Diff 15359.May 16 2019, 12:52 AM

Rename variables, comments

Harbormaster completed remote builds in B3600: Diff 15360.May 16 2019, 1:17 AM

Thanks, committed rB8a6414ed46f669ede106b3ffbe48f74b47718e11

This revision is now accepted and ready to land.May 16 2019, 1:41 AM

Campbell Barton (campbellbarton) closed this revision.May 16 2019, 1:41 AM

Fix High Priority T54686: Multi-Object-Mode: EditMesh GL selection objects don't occlude eachother
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 15360

source/blender/draw/DRW_engine.h

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_mesh.h

source/blender/editors/mesh/CMakeLists.txt

source/blender/editors/mesh/editface.c

source/blender/editors/mesh/editmesh_loopcut.c

source/blender/editors/mesh/editmesh_select.c

source/blender/editors/mesh/meshtools.c

source/blender/editors/sculpt_paint/paint_utils.c

source/blender/editors/space_view3d/drawobject.c

source/blender/editors/space_view3d/view3d_draw_legacy.c

source/blender/editors/space_view3d/view3d_gizmo_preselect_type.c

source/blender/editors/space_view3d/view3d_intern.h

source/blender/editors/space_view3d/view3d_select.c

Fix High Priority T54686: Multi-Object-Mode: EditMesh GL selection objects don't occlude eachotherClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15360

source/blender/draw/DRW_engine.h

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_mesh.h

source/blender/editors/mesh/CMakeLists.txt

source/blender/editors/mesh/editface.c

source/blender/editors/mesh/editmesh_loopcut.c

source/blender/editors/mesh/editmesh_select.c

source/blender/editors/mesh/meshtools.c

source/blender/editors/sculpt_paint/paint_utils.c

source/blender/editors/space_view3d/drawobject.c

source/blender/editors/space_view3d/view3d_draw_legacy.c

source/blender/editors/space_view3d/view3d_gizmo_preselect_type.c

source/blender/editors/space_view3d/view3d_intern.h

source/blender/editors/space_view3d/view3d_select.c

Fix High Priority T54686: Multi-Object-Mode: EditMesh GL selection objects don't occlude eachother
ClosedPublic
Actions

Revision Contents
Changeset List