Page MenuHome
Differential D4868

VSE: add movie strips on top of audio
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on May 16 2019, 2:15 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T64661: VSE: Place audio strips under video
Summary
  • add movies to channel above free slot (no check for 2 free slots)
  • add sound to the free slot

This code is bad just by looking at it :[
I guess that worst is, that it silently overrides channel operator property.
We can not set channel in python anyway and there is another code that can override decision made by this operator...

This seems to be rabbithole I don't really want to deal with at this point - see T59540: VSE timeline manipulation API

Diff Detail

Repository
rB Blender
Branch
T64661 (branched from master)
Build Status
Buildable 3646
Build 3646: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) created this revision.May 16 2019, 2:15 AM
Harbormaster completed remote builds in B3601: Diff 15361.May 16 2019, 2:15 AM
Richard Antalik (ISS) added inline comments.May 16 2019, 11:36 AM
source/blender/editors/space_sequencer/sequencer_add.c
169

Maybe I should add check if the channel property is set here.
That will at least restore it's function

Richard Antalik (ISS) updated this revision to Diff 15401.May 16 2019, 10:07 PM
  • don't override channel settings if channel property is set
Harbormaster completed remote builds in B3620: Diff 15401.May 16 2019, 10:07 PM
Brecht Van Lommel (brecht) requested changes to this revision.May 18 2019, 8:33 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/space_sequencer/sequencer_add.c
176

frame_end should be channel?

This revision now requires changes to proceed.May 18 2019, 8:33 PM
Richard Antalik (ISS) updated this revision to Diff 15444.May 18 2019, 9:12 PM
  • fix typo
Harbormaster completed remote builds in B3646: Diff 15444.May 18 2019, 9:12 PM
Brecht Van Lommel (brecht) accepted this revision.May 18 2019, 10:17 PM
This revision is now accepted and ready to land.May 18 2019, 10:17 PM
Richard Antalik (ISS) closed this revision.Jun 6 2019, 9:44 PM

Closed by 58bea005c58956674c7f4a9a7a85ff943c140f03

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
4 lines
editors/
space_sequencer/
8 lines

Diff 15444

View Options

source/blender/blenkernel/intern/sequencer.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_add.c

Loading...