Details
- Reviewers
Sergey Sharybin (sergey) Stefan Werner (swerner) - Group Reviewers
Render & Cycles - Maniphest Tasks
- T54113: Render Artifacts with SSS + Motion Blur + Use Spacial Splits
Diff Detail
- Repository
- rB Blender
Event Timeline
Nice catch!
| intern/cycles/bvh/bvh_split.cpp | ||
|---|---|---|
| 355 | Think we should indeed switch to nullptr, but currently Cycles uses old-style NULL. Probably better be consistent for now and do the switch in the whole source base (making it even possible to use nullptr in the kernel code). | |
Can't spot any mistakes, tests are passing, verified that report is fixed.
@Stefan Werner (swerner), anything from your side?
@MATILLAT Quentin (qmatillat), did you set up your account to be able to commit and such (Bastien mailed the list about this recently) ?
I have setup my git access.
BTW, I was wondering if the same issue was applicable to curve. I'm not sure if motion blur can be used on curve, but in that case, I think we have the same issue on curve (in split_curve_primitive).
This patch was not committed back when it was approved, so I'm adding the Cycles module as blocking review to either validate it (and commit) or to just close it.
Was double-checking the change again now. There are still some artifacts with spatial splits used. Needs deeper investigation.
Setting status as "Requested Changes" to indicate that the patch is not ready to be committed yet.