Page MenuHome

Add-ons: remove temporary disabling of use_global_undo
ClosedPublic

Authored by Brecht Van Lommel (brecht) on May 21 2019, 11:15 AM.

Details

Summary

This can cause bugs where if the operator throws and exception, undo is not
properly enabled again. There have been maybe a dozen Blender bug reports
related to this. This could get worse now that we are autosaving preferences.

Some add-ons guard against this, but turning off undo should not be needed in
the first place. If the operator is set to do an undo push, any operators it
calls will automatically not do any undo pushes.

If this fail in some cases, it should be reported as a bug in Blender. I could
not find issues or a performance impact testing a few add-ons though.

Diff Detail

Event Timeline

Harbormaster completed remote builds in B3663: Diff 15494.

Did not know some add-ons were doing that… With preferences auto-save, this is indeed a very bad thing to do now, so totally fine with that patch.

This revision is now accepted and ready to land.May 21 2019, 11:38 AM
This revision was automatically updated to reflect the committed changes.