DrawManager: Color Management
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on May 21 2019, 12:23 PM.

Details

Reviewers

Clément Foucault (fclem)
Antonio Vazquez (antoniov)

Maniphest Tasks

T64849: EEVEE Viewport render: multisampling is ignored when drawing object lines

Commits

rBS23064248d7a0: DrawManager: Color Management
rB23064248d7a0: DrawManager: Color Management

Summary

The draw manager used to determine if the view transform should be
applied by checking if the scene was not rendered to an offscreen image.

As the sequencer needs to render to an offscreen image with the view
transform applied we need to separate the do_color_management from the
is_image_render.

Diff Detail

Repository

rB Blender

Branch

T64849b (branched from master)

Build Status

Buildable 3665
Build 3665: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.May 21 2019, 12:23 PM

Harbormaster completed remote builds in B3665: Diff 15496.May 21 2019, 12:24 PM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).May 21 2019, 12:27 PM

Also not 100% sure if/how we should attach this to Grease Pencil.

GP copies the is_image_render locally and turns off tonemapping for when rendering. Colors in the viewport vs image rendering are different in filmic (current state in master). I think we should also connect the tonemapping setting to DRW_state_do_color_management.