Fix T64827: "Batch-Generate Previews" crashes
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 21 2019, 5:26 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Bastien Montagne (mont29)

Maniphest Tasks

T64827: "Batch-Generate Previews" crashes

Diff Detail

Repository

rB Blender

Branch

T64827 (branched from master)

Build Status

Buildable 3678
Build 3678: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.May 21 2019, 5:26 PM

Harbormaster completed remote builds in B3678: Diff 15520.May 21 2019, 5:26 PM

two notes (havent investigated yet, not sure if required for the fix?):

there is a memleak somewhere (Not freed memory blocks: 246, total unfreed memory 0.103485 MB in simple scene)
previews have alpha issue?

LGTM (besides note below).

Memleak needs to be tracked down though (probably not directly caused by that script, needs to be investigated), as well as alpha issue (things were changed a lot regarding image alpha in some places, not sure whether that is affecting us here…)

release/scripts/modules/bl_previews_utils/bl_previews_render.py
305–307	you should probably be able to only call `update` on `context.view_layer` ? `scene.update()` was dropped precisely to avoid updating all viewlayers, afaik… (same for other cases below)