Page MenuHome

Depsgraph: Don't tag original IDs for recalc
ClosedPublic

Authored by Sergey Sharybin (sergey) on May 22 2019, 12:25 PM.

Details

Summary

Tagging original ID introduces a conflict of interest when a separate
graph is created and is tagging objects to be re-evaluated with its
context.

This is part of the problem in T63111: tags within a temporary dependency
graph affects viewport and vice versa, which makes logic to wrongly
consider that something did change in the scene and that baking is to
be redone.

This effectively reverts db3bfd0, but this time everything seems to
be updating fine in the viewport.

Eevee: Ignore COW tag when deciding on auto-bake

This is too generic flag, and it might be used by anything, starting from
changes in transform ending with changes in ID properties.

The check here is to be as specific as possible. If that is not possible
the decision must be documented.

Related on T63111.

Diff Detail

Repository
rB Blender
Branch
eevee_fix_autobake (branched from master)
Build Status
Buildable 3686
Build 3686: arc lint + arc unit

Event Timeline

I couldn't find anything that breaks with this, so looks good to me.

This revision is now accepted and ready to land.May 23 2019, 4:31 PM
This revision was automatically updated to reflect the committed changes.