Depsgraph: Fix fake dependnecy cycle in proxies
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on May 23 2019, 10:29 AM.

Details

Reviewers

Alexander Gavrilov (angavrilov)
Brecht Van Lommel (brecht)

Commits

rBS028bce87173e: Depsgraph: Fix fake dependnecy cycle in proxies
rB028bce87173e: Depsgraph: Fix fake dependnecy cycle in proxies

Summary

Noticed when was looking into T64764, F7043663.

This is a weird case when proxy group is not a group, but is the
same as linked object.

Remove useless relation which was causing cycle, but had no functional
meaning.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) created this revision.May 23 2019, 10:29 AM

Harbormaster completed remote builds in B3694: Diff 15550.May 23 2019, 10:29 AM

Can you explain the reasoning behind this?

It's not clear to me why this created a dependency cycles, or why it's valid to depend on TRANSFORM_EVAL without for example TRANSFORM_FINAL that sets ob->imat.

Result of pair programming with Brecht.

Harbormaster completed remote builds in B3697: Diff 15555.May 23 2019, 3:07 PM

Sergey Sharybin (sergey) edited the summary of this revision. (Show Details)May 23 2019, 3:08 PM

Brecht Van Lommel (brecht) accepted this revision.May 23 2019, 3:08 PM

This revision is now accepted and ready to land.May 23 2019, 3:08 PM

Closed by commit rB028bce87173e: Depsgraph: Fix fake dependnecy cycle in proxies (authored by Sergey Sharybin (sergey)). · Explain WhyMay 23 2019, 3:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

depsgraph/

intern/

builder/

deg_builder_relations.cc

4 lines

Diff 15557

View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Depsgraph: Fix fake dependnecy cycle in proxiesClosedPublicActions