Page MenuHome
Differential D4942

EEVEE: Volumetrics
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on May 24 2019, 4:24 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T64922: Blender crashes when View port sampling is set to 1 with an object that has volume
Commits
rBS5986160dd0f1: EEVEE: Volumetrics
rB5986160dd0f1: EEVEE: Volumetrics
Summary

When viewport samples are set to 1 simple scenes with volumetrics crash.
EEVEE volumetrics needs to init the post processing buffers. With recent
changes the need for post processing buffers are known after the cache
init. But they are constructed before the cache init. This lead to null
pointers.

Diff Detail

Repository
rB Blender
Branch
T64922 (branched from master)
Build Status
Buildable 3718
Build 3718: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.May 24 2019, 4:24 PM
Harbormaster completed remote builds in B3718: Diff 15584.May 24 2019, 4:24 PM
Jeroen Bakker (jbakker) updated this revision to Diff 15585.May 24 2019, 4:27 PM

Cleaned up

Harbormaster completed remote builds in B3719: Diff 15585.May 24 2019, 4:27 PM
Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).May 24 2019, 4:27 PM
Clément Foucault (fclem) accepted this revision.May 24 2019, 4:31 PM
This revision is now accepted and ready to land.May 24 2019, 4:31 PM
Closed by commit rB5986160dd0f1: EEVEE: Volumetrics (authored by Jeroen Bakker (jbakker)). · Explain WhyMay 24 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
eevee/
2 lines
2 lines

Diff 15584

View Options

source/blender/draw/engines/eevee/eevee_effects.c

Loading...
View Options

source/blender/draw/engines/eevee/eevee_volumes.c

Loading...