CloudAddon: Build process
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on May 27 2019, 9:32 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Commits

rBCAc457767edf81: Use Python module to run Pip

Summary

setup.py used systemcalls for package management pip. This call is
platform dependent as on ubuntu distros this needs to be pip3. On
these platforms pip points to the python2 version.

By direct calling the pip module from within the running python process
we know for sure we are triggering the correct one.

Diff Detail

Repository

rBCA Blender Cloud Addon

Branch

master

Build Status

Buildable 3738
Build 3738: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.May 27 2019, 9:32 AM

Harbormaster completed remote builds in B3738: Diff 15617.May 27 2019, 9:32 AM

Jeroen Bakker (jbakker) added a reviewer: Sybren A. Stüvel (sybren).May 27 2019, 9:33 AM

Jeroen Bakker (jbakker) mentioned this in rBCAad7e9acb5d6a: Using pillarsdk from pypi.

Looks good to me.

We always work within a virtualenv, in which case python, pip etc. all point to the correct versions. Your approach avoids starting a subprocess and is automatically working on all environments, so good one!

This revision is now accepted and ready to land.May 27 2019, 11:55 PM

Closed by commit rBCAc457767edf81: Use Python module to run Pip (authored by Jeroen Bakker (jbakker), committed by Sybren A. Stüvel (sybren)). · Explain WhyMay 29 2019, 10:36 AM

This revision was automatically updated to reflect the committed changes.

Merged in rBCAc457767edf814f92e1da8cb9d08fa52404ea074c