Sequencer Menus - minor bug fixes
ClosedPublic
Actions

Authored by Peter Fog (tintwotin) on May 27 2019, 2:45 PM.

Details

Reviewers

William Reynish (billreynish)
Richard Antalik (ISS)
Brecht Van Lommel (brecht)

Commits

rBS451c533e25dd: VSE: Menu bug fixes
rB451c533e25dd: VSE: Menu bug fixes

Summary

Fixes:
Toggle Meta unfortunately disappeared in the Strip Menu previous commit. This function is back now in it's original place.

Moved position of Lock/Mute in Strip Menu to match position in Context Menu.

All icons was removed from the menus, but the Lock icon was still left. It has now been removed.

[REMOVED from the original patch: Waveform toggle button added to Strip/Context menu, and is only visible when a Sound strip is selected.

Removed "Rebuilt Proxies..." and "Deinterlace Selected Movies" from the Strip menu.
We'll have to avoid getting the menu that long, that scrolling is needed.
Both functions are also located in the Sidebar.]

Diff Detail

Event Timeline

Peter Fog (tintwotin) created this revision.May 27 2019, 2:45 PM

Adding waveform toggle is not a bugfix, that should not be done at this stage. Having operators that only affect the active strip in menus is probably not correct anyway.

Removing rebuild proxies and deinterlace also do not seem like bugfixes.

Waveform toggle removed.
Deinterlace is back in the menu.
So is Rebuilt proxies...

I am lost in this UI rework, so correct me if I am not getting something.

release/scripts/startup/bl_ui/space_sequencer.py
608	Do you want to remove this icon? Why?
639	This line shouldn't be here. It is here because there are some characters at the end of the line (whitespace) It is best to remove those prior to submission
706	Also whitespace here

I could also fix those whitespace issues also, but as I know myself I would forget to do it and commit blindly, so please fix that.

release/scripts/startup/bl_ui/space_sequencer.py
608	Sorry, turns out, I can not read and comprehend at once - it is written in the description. You can mark this as resolved

This revision now requires changes to proceed.May 28 2019, 12:23 AM

I wish the Blender text editor would have a 'Remove Trailing Whitespace' feature or a feature to show invisible characters. Anyway, when I remove the whitespaces, it is not enough for Sourcetree to detect any change to make a patch. If I add a commented letter, only that letter will be included in patch. I'm confused, did you already submit this commit? (This is my first attempt to do this patching stuff...)

In D4957#113340, @Peter Fog (tintwotin) wrote:

I wish the Blender text editor would have a 'Remove Trailing Whitespace' feature or a feature to show invisible characters.

I would suggest to use some other editor - perhaps sublime or notepad++

Anyway, when I remove the whitespaces, it is not enough for Sourcetree to detect any change to make a patch. If I add a commented letter, only that letter will be included in patch. I'm confused, did you already submit this commit? (This is my first attempt to do this patching stuff...)

I didn't commit this yet.

We can talk about this in blender.chat, @ me, I should be available today.

Removed whitespaces.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)May 28 2019, 10:56 AM

Richard Antalik (ISS) accepted this revision.May 29 2019, 12:01 AM

This revision is now accepted and ready to land.May 29 2019, 12:01 AM

William Reynish (billreynish) accepted this revision.May 29 2019, 12:22 AM

I guess either of you can commit this.

Brecht Van Lommel (brecht) accepted this revision.May 29 2019, 1:21 PM

Closed by commit rB451c533e25dd: VSE: Menu bug fixes (authored by Richard Antalik (ISS)). · Explain WhyMay 31 2019, 1:26 AM

This revision was automatically updated to reflect the committed changes.