Page MenuHome
Differential D4963

Fix T57090: selected node group input sockets circles not drawing in sidebar UIList
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on May 28 2019, 11:05 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Maniphest Tasks
T57090: Node group input sockets not drawing in sidebar
Commits
rBSb2b1aa2f8ead: Fix T57090: selected node group input sockets circles not drawing in sidebar…
rBb2b1aa2f8ead: Fix T57090: selected node group input sockets circles not drawing in sidebar…
Summary

nodesockets were actually drawn, but immediately drawn over by widgets
from the widget draw batch cache.

solution here is to "widgify" nodesocket drawing as well.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.May 28 2019, 11:05 AM
Harbormaster completed remote builds in B3750: Diff 15647.May 28 2019, 11:05 AM
Harbormaster completed remote builds in B3750: Diff 15647.
Philipp Oeser (lichtwerk) mentioned this in T57090: Node group input sockets not drawing in sidebar.May 28 2019, 11:06 AM

bit more info in T57090 itself...

Brecht Van Lommel (brecht) accepted this revision.May 28 2019, 11:51 AM

Always nice if the code is simpler after a bugfix.

This revision is now accepted and ready to land.May 28 2019, 11:51 AM
Closed by commit rBb2b1aa2f8ead: Fix T57090: selected node group input sockets circles not drawing in sidebar… (authored by Philipp Oeser (lichtwerk)). · Explain WhyMay 28 2019, 12:27 PM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) awarded a token.May 28 2019, 2:19 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
98 lines
4 lines
42 lines

Diff 15648

View Options

source/blender/editors/interface/interface_draw.c

Loading...
View Options

source/blender/editors/interface/interface_intern.h

Loading...
View Options

source/blender/editors/interface/interface_widgets.c

Loading...