Page MenuHome
Differential D4974

TexturePaint: Projection Edit
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on May 29 2019, 1:29 PM.

Details

Reviewers
Clément Foucault (fclem)
Brecht Van Lommel (brecht)
Maniphest Tasks
T63862: Quick Edit doesn't adjust background and overlays
Commits
rBaf1e94413ab6: TexturePaint: Projection Edit
Summary

Disable all overlays except the texture paint overlay. Add alpha to the
resulting image buffer.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.May 29 2019, 1:29 PM
Harbormaster completed remote builds in B3766: Diff 15675.May 29 2019, 1:29 PM
Jeroen Bakker (jbakker) retitled this revision from TexturePaint: Projection Edit to TexturePaint: Projection Edit (WIP).May 29 2019, 1:30 PM
Jeroen Bakker (jbakker) updated this revision to Diff 15678.May 29 2019, 2:38 PM

Draw background transparent. Please note that this patch required D4909: DrawManager: Color Management to work.

Harbormaster completed remote builds in B3769: Diff 15678.May 29 2019, 2:38 PM
Jeroen Bakker (jbakker) added inline comments.May 29 2019, 2:39 PM
source/blender/editors/sculpt_paint/paint_image_proj.c
6192

remove the = {NULL}

Jeroen Bakker (jbakker) retitled this revision from TexturePaint: Projection Edit (WIP) to TexturePaint: Projection Edit.May 29 2019, 2:41 PM
Jeroen Bakker (jbakker) added reviewers: Clément Foucault (fclem), Brecht Van Lommel (brecht).
Jeroen Bakker (jbakker) added a parent revision: D4909: DrawManager: Color Management.
Brecht Van Lommel (brecht) requested changes to this revision.May 29 2019, 2:45 PM

This also should hide gizmos I think?

It seems a little simpler to modify the copy and then pass that to the function, instead of restoring data in the original.

This revision now requires changes to proceed.May 29 2019, 2:45 PM
Brecht Van Lommel (brecht) added inline comments.May 29 2019, 2:45 PM
source/blender/editors/sculpt_paint/paint_image_proj.c
6192

Could just do View3D v3d_copy = *v3d; perhaps.

Jeroen Bakker (jbakker) updated this revision to Diff 15697.May 31 2019, 9:00 AM

Hide GIZMO (I do dislike negative code and substractive flags :-) )

Harbormaster completed remote builds in B3776: Diff 15697.May 31 2019, 9:00 AM
Jeroen Bakker (jbakker) marked an inline comment as done.May 31 2019, 9:01 AM
Brecht Van Lommel (brecht) accepted this revision.Jun 17 2019, 3:32 PM
This revision is now accepted and ready to land.Jun 17 2019, 3:32 PM
Closed by commit rBaf1e94413ab6: TexturePaint: Projection Edit (authored by Jeroen Bakker (jbakker)). · Explain WhyJun 18 2019, 11:15 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rBaf1e94413ab6: TexturePaint: Projection Edit.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
workbench/
4 lines
editors/
sculpt_paint/
22 lines

Diff 15947

View Options

source/blender/draw/engines/workbench/workbench_data.c

Loading...
View Options

source/blender/editors/sculpt_paint/paint_image_proj.c

Loading...