Page MenuHome
Differential D5001

Scrollbars never get too small to grab
ClosedPublic
Actions

Authored by Eitan Traurig (EitanSomething) on Jun 3 2019, 4:47 PM.

Details

Reviewers
William Reynish (billreynish)
Jacques Lucke (JacquesLucke)
Commits
rBScd90986bcb4e: UI: Prevent scrollbars from getting too small to grab
rBcd90986bcb4e: UI: Prevent scrollbars from getting too small to grab
Summary

Set the scrollbars to a set size of 50 or greater so the handles can always be grabbed

Before


After

Diff Detail

Repository
rB Blender

Event Timeline

Eitan Traurig (EitanSomething) created this revision.Jun 3 2019, 4:47 PM
Eitan Traurig (EitanSomething) created this object with edit policy "Eitan Traurig (EitanSomething)".
Eitan Traurig (EitanSomething) edited the summary of this revision. (Show Details)Jun 3 2019, 4:53 PM
William Reynish (billreynish) added subscribers: Jacques Lucke (JacquesLucke), Pablo Vazquez (pablovazquez).Jun 3 2019, 4:56 PM

you've locked editing, so I'm unable to add @Pablo Vazquez (pablovazquez) and @Jacques Lucke (JacquesLucke)

Eitan Traurig (EitanSomething) changed the edit policy from "Eitan Traurig (EitanSomething)" to "All Users".Jun 3 2019, 4:59 PM
In D5001#114124, @William Reynish (billreynish) wrote:

you've locked editing, so I'm unable to add @Pablo Vazquez (pablovazquez) and @Jacques Lucke (JacquesLucke)

Fixed it

Jacques Lucke (JacquesLucke) added a comment.Jun 3 2019, 4:59 PM

Please do not hardcode the 50 in so many places. Just use a define like V2D_MIN_SCROLLER_SIZE.

Jacques Lucke (JacquesLucke) requested changes to this revision.Jun 3 2019, 5:00 PM
This revision now requires changes to proceed.Jun 3 2019, 5:00 PM
William Reynish (billreynish) requested changes to this revision.Jun 3 2019, 5:06 PM

This doesn't take UI scale into account

Eitan Traurig (EitanSomething) updated this revision to Diff 15741.Jun 3 2019, 5:07 PM
Jacques Lucke (JacquesLucke) added a comment.Jun 3 2019, 5:08 PM

Also you forgot to actually use the V2D_MIN_SCROLLER_SIZE define now.

Eitan Traurig (EitanSomething) updated this revision to Diff 15743.Jun 3 2019, 5:18 PM
This comment was removed by Eitan Traurig (EitanSomething).
William Reynish (billreynish) requested changes to this revision.EditedJun 3 2019, 5:26 PM

At least here, the minimum scrollbar size is now HUGE:

50 * widget_scale is actually massive. Should be 50 * ui_scale I think

This revision now requires changes to proceed.Jun 3 2019, 5:26 PM
William Reynish (billreynish) added inline comments.Jun 3 2019, 5:28 PM
source/blender/editors/include/UI_view2d.h
73

Isn't it U.ui_scale and not widget_scale?

Eitan Traurig (EitanSomething) updated this revision to Diff 15745.Jun 3 2019, 5:33 PM

Update:

1:No longer hard coded
2:Scale when resolution scale not default

Jacques Lucke (JacquesLucke) added inline comments.Jun 3 2019, 5:34 PM
source/blender/editors/include/UI_view2d.h
73

Use UI_DPI_FAC instead of U.ui_scale.

William Reynish (billreynish) added a comment.Jun 3 2019, 5:35 PM

@Jacques Lucke (JacquesLucke) Ah yes, sorry, you are right.

Eitan Traurig (EitanSomething) updated this revision to Diff 15747.Jun 3 2019, 5:36 PM
Eitan Traurig (EitanSomething) marked an inline comment as done.

Update

1:Use UI_DPI_FAC instead of U.ui_scale

William Reynish (billreynish) accepted this revision.Jun 3 2019, 5:51 PM

This seems to work well now.

Jacques Lucke (JacquesLucke) accepted this revision.Jun 3 2019, 6:09 PM
This revision is now accepted and ready to land.Jun 3 2019, 6:09 PM
Closed by commit rBcd90986bcb4e: UI: Prevent scrollbars from getting too small to grab (authored by Eitan Traurig (EitanSomething), committed by Jacques Lucke (JacquesLucke)). · Explain WhyJun 3 2019, 6:19 PM
This revision was automatically updated to reflect the committed changes.
Pablo Vazquez (pablovazquez) awarded a token.Jun 4 2019, 11:47 AM
Eitan Traurig (EitanSomething) mentioned this in T65740: Scrollbars still scroll scene even if scrollbars aren't moving..Jun 12 2019, 5:52 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
2 lines
interface/
21 lines

Diff 15751

View Options

source/blender/editors/include/UI_view2d.h

Loading...
View Options

source/blender/editors/interface/view2d.c

Loading...