TexturePaint: Missing Texture Depth Test
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Jun 4 2019, 11:31 AM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T64615: Texture Paint Overlay Visual Glitch

Commits

rBSeeda9369b6e6: TexturePaint: Missing Texture Depth Test
rBeeda9369b6e6: TexturePaint: Missing Texture Depth Test

Summary

Depth testing was off as it used the precomputed ModelView matrix. As
draw engines currently use a different approach the depth was sometimes
a bit off making the color disappear.

This change will use a different vertex shader that will write the
correct depth. I expected the same change to be needed in the bone
selection overlay but was not able to reproduce it.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Jun 4 2019, 11:31 AM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).Jun 4 2019, 11:32 AM

Harbormaster completed remote builds in B3808: Diff 15758.Jun 4 2019, 11:32 AM

Clément Foucault (fclem) added inline comments.Jun 4 2019, 11:36 AM

source/blender/draw/modes/shaders/paint_face_vert.glsl
11	Isn't this still needed?

Jeroen Bakker (jbakker) added inline comments.Jun 5 2019, 1:50 PM

source/blender/draw/modes/shaders/paint_face_vert.glsl
11	I seems to be that there is wrong interpretation of the diff.... will update

Jeroen Bakker (jbakker) marked an inline comment as done.Jun 5 2019, 2:21 PM

Jeroen Bakker (jbakker) added inline comments.

source/blender/draw/modes/shaders/paint_face_vert.glsl
11	Ah. this is not needed we are looking to the `paint_face_vert.glsl` this shader only draws the missing texture color. the `paint_face_selection_vert.glsl` has the logic to not draw selected faces.