Page MenuHome
Differential D5045

Fix T61948: Undo steps created for non-paint operations (brush size).
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jun 8 2019, 5:09 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Summary

The workaround for this patch was to force the undo type/context of the buttons to be BKE_UNDOSYS_TYPE_MEMFILE.
I don't know what impact this has on memory, but usability has been greatly improved in several ways.

In addition to T61948 this patch also benefits T62450 since the undo now re-displays the visibility of hidden objects.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 3855
Build 3855: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jun 8 2019, 5:09 PM
Harbormaster completed remote builds in B3855: Diff 15855.Jun 8 2019, 5:09 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Jun 8 2019, 5:10 PM
Germano Cavalcante (mano-wii) planned changes to this revision.Jun 8 2019, 6:42 PM

I'm having trouble undoing a painting operation :\

Campbell Barton (campbellbarton) added a comment.Jul 2 2019, 9:27 AM

For 2.80 it's probably safest to skip these undo steps, (as 2.7x did), later we can look into supporting this.

Germano Cavalcante (mano-wii) abandoned this revision.Dec 24 2019, 10:07 PM

Original issue already resolved.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
1 line
interface/
2 lines
undo/
19 lines

Diff 15855

View Options

source/blender/editors/include/ED_undo.h

Loading...
View Options

source/blender/editors/interface/interface_handlers.c

Loading...
View Options

source/blender/editors/undo/ed_undo.c

Loading...