Fix T65640: Axis of Custom Shape Bones are drawn in a wrong position.
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jun 10 2019, 1:42 AM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T65640: Wrong axis location on bones with custom widgets

Commits

rB6f5ef60f1b50: Fix T65640: Axis of Custom Shape Bones are drawn in a wrong position.

Summary

The problem is that Custom Shape Bones can also have a custom size.
So the pchan->disp_mat doesn't always consider the actual length of the bone.
The proposed solution is to calculate the axes matrix at the drawing pass.

Ref T65640

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jun 10 2019, 1:42 AM

Harbormaster completed remote builds in B3856: Diff 15859.Jun 10 2019, 1:42 AM

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Dec 24 2019, 9:51 PM

Germano Cavalcante (mano-wii) added a task: T65640: Wrong axis location on bones with custom widgets.

I'm going to commit a slightly different version where I optimized the matrix mul and only do that if custom bones are effectly used.

This revision is now accepted and ready to land.Feb 20 2020, 12:50 AM

Closed by commit rB6f5ef60f1b50: Fix T65640: Axis of Custom Shape Bones are drawn in a wrong position. (authored by Germano Cavalcante (mano-wii), committed by Clément Foucault (fclem)). · Explain WhyFeb 20 2020, 12:53 AM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rB6f5ef60f1b50: Fix T65640: Axis of Custom Shape Bones are drawn in a wrong position..

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

overlay_armature.c

36 lines

Diff 21906

View Options

source/blender/draw/engines/overlay/overlay_armature.c

Fix T65640: Axis of Custom Shape Bones are drawn in a wrong position.ClosedPublicActions