Draw Armature: Move `disp_mat` update out of draw_manager.
Changes PlannedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jun 10 2019, 3:00 PM.

Details

Reviewers

Clément Foucault (fclem)
Sergey Sharybin (sergey)

Summary

This is part of a TODO.
These matrices don't have to be recalculated on each redraw.
Currently only ptchans benefit from this patch.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 7175
Build 7175: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jun 10 2019, 3:00 PM

Harbormaster completed remote builds in B3858: Diff 15864.Jun 10 2019, 3:00 PM

This needs to be update to latest master.

I'm committed to see this being merged.

source/blender/draw/intern/draw_armature.c
1063 ↗	(On Diff #15864)	use rescale_m4
1065 ↗	(On Diff #15864)	you can replace this by `add_v3v3(eBone->disp_tail_mat[3], eBone->disp_tail_mat[1]);`
1256 ↗	(On Diff #15864)	dont change prefix

This revision now requires changes to proceed.Mar 13 2020, 12:47 AM

Rebase master

Harbormaster completed remote builds in B7175: Diff 22835.Mar 16 2020, 1:43 PM

A lot has changed and I'm not sure anymore (I don't remember) how disp_mat and disp_tail_mat are used.
I also have to double check the depsgraph functions to see if something is missing.
It would also be good to implement this update for eBones.

(I would also like to check the need to have these matrices)