Differential D505

Minor changes
ClosedPublic
Actions

Authored by Keir Mierle (keir) on May 7 2014, 11:41 AM.

Tags

None

Subscribers

None

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rLMV0618f1c8e88d: Minor changes

Diff Detail

Repository: rLMV Libmv
Branch: minor

Event Timeline

Fix

Sergey Sharybin (sergey) added inline comments.May 7 2014, 11:46 AM

src/libmv/autotrack/autotrack.h
55	It's unclear for me how would you synchronize multiple clips. They're probably wouldn't have the same exact timebase, meaning clip1 could have been started shooting some seconds later than clip0. From the real camera POV it's all about timecode, which we can get into account in blender. But seems somehow we need to pass it to Libmv?
68	Is it an empty line?
81	Add underscope suffix to all the private guys?

Comments

src/libmv/autotrack/autotrack.h
55	Time synchronization doesn't matter; within a single autotrack it is always assumed that the scene is static. The "clip" notion is purely to make it clear that images are part of a sequence (or not) and that they may have a small baseline.
68	Fixed
81	Fixed

Sergey Sharybin (sergey) accepted this revision.May 7 2014, 12:02 PM

Closed by commit rLMV0618f1c8e88d (authored by @Keir Mierle (keir)).

Revision Contents
Changeset List

Path

Size

src/

libmv/

autotrack/

48 lines

frame_accessor.h

2 lines

tracking/

6 lines

Diff 1642

src/libmv/autotrack/autotrack.h

Loading...

src/libmv/autotrack/frame_accessor.h

Loading...

src/libmv/tracking/track_region.h

Loading...