Page MenuHome
Differential D5071

Check if GPencil object is in edit mode
AbandonedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Jun 13 2019, 8:02 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
William Reynish (billreynish)
Summary

This check is to round with a circle the outliner icon when is in Edit mode

Diff Detail

Event Timeline

Antonio Vazquez (antoniov) created this revision.Jun 13 2019, 8:02 PM
Antonio Vazquez (antoniov) mentioned this in T65783: UI Inconsistency with Grease Pencil icons in Properties and Outliner.
Antonio Vazquez (antoniov) added a reviewer: William Reynish (billreynish).
Brecht Van Lommel (brecht) requested changes to this revision.Jun 13 2019, 8:31 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/space_outliner/outliner_draw.c
120–125

I think this can be simplified to:

if (id_type == ID_GD && obact && obact->data == id) {
  bGPdata *gpd = (bGPdata *)id;
  return GPENCIL_EDIT_MODE(gpd);
}

Comparing name to check if it's the same datablock is wrong in case there are linked datablocks with the same name, and it's simpler to compare pointers anyway.

This revision now requires changes to proceed.Jun 13 2019, 8:31 PM
Antonio Vazquez (antoniov) mentioned this in rB1688a57a8e68: Fix T65783: Gpencil Edit mode doesn't round data icon.Jun 13 2019, 8:38 PM
Antonio Vazquez (antoniov) abandoned this revision.Jun 13 2019, 8:39 PM

Already committed with @Brecht Van Lommel (brecht) suggestions.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_outliner/
8 lines

Diff 15901

View Options

source/blender/editors/space_outliner/outliner_draw.c

Loading...