Page MenuHome
Differential D5081

Fix T65834: Circle Select does not update select_id buffer after orbiting view3d.
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jun 15 2019, 11:40 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rB3039d86f8bc0: Fix T65834: Circle Select does not update select_id buffer after orbiting…
Summary

It is possible to navigate through view3d during the circle select operation.
That said, it looks like the V3D_INVALID_BACKBUF flag would be very useful.
But since it is still inficient to check for real changes, the solution proposed in this patch is to check for changes in the perspective matrix.

Report: T65834

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 3883
Build 3883: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Jun 15 2019, 11:40 PM
Harbormaster completed remote builds in B3883: Diff 15927.Jun 15 2019, 11:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 21 2019, 5:06 PM
Closed by commit rB3039d86f8bc0: Fix T65834: Circle Select does not update select_id buffer after orbiting… (authored by Germano Cavalcante (mano-wii)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB3039d86f8bc0: Fix T65834: Circle Select does not update select_id buffer after orbiting….

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
3 lines
space_view3d/
15 lines

Diff 15927

View Options

source/blender/editors/include/ED_view3d.h

Loading...
View Options

source/blender/editors/space_view3d/view3d_select.c

Loading...