Fix T65889: Hair Particles not updating in Viewport when using Influence Textures (image sequences)
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jun 18 2019, 2:07 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T65889: Hair Particles not updating in Viewport when using image sequence textures to drive Hair Size

Summary

just dropping this here because it works, pretty sure though there is a cleaner way of doing things...

Diff Detail

Repository

rB Blender

Branch

T65889 (branched from master)

Build Status

Buildable 3890
Build 3890: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jun 18 2019, 2:07 PM

Harbormaster completed remote builds in B3890: Diff 15951.Jun 18 2019, 2:07 PM

Philipp Oeser (lichtwerk) mentioned this in T65889: Hair Particles not updating in Viewport when using image sequence textures to drive Hair Size.Jun 18 2019, 2:07 PM

bring back unneccessary removal

Harbormaster completed remote builds in B3891: Diff 15952.Jun 18 2019, 2:15 PM

Sergey Sharybin (sergey) added inline comments.Jun 18 2019, 3:25 PM

source/blender/depsgraph/intern/builder/deg_builder_relations.cc
1780–1785	Think particle should always be dependent on its texture.
2233–2239	This should be using the following chain of relations: Time Source -> Image -> Texture.

Setting as Request Changes to make the state of this patch clear.

This revision now requires changes to proceed.Jun 21 2019, 5:28 PM

Philipp Oeser (lichtwerk) added inline comments.Jun 21 2019, 7:04 PM

source/blender/depsgraph/intern/builder/deg_builder_relations.cc
1780–1785	they are (see code just above). this is just adding the relation to `cow` texture (if it has animated images)
2233–2239	totally agree, tbh, I just didnt get it to work... The way the operation code works `DepsgraphNodeBuilder::build_animation_images` / `BKE_image_user_id_eval_animation` it works on related cow ID and I dont see how to set up a (working) relation to the Image directly, thats why I went `Time Source > Texture > Particle` Maybe @Brecht Van Lommel (brecht) can comment (but I will also check this again with fresh eyes next week...)

Philipp Oeser (lichtwerk) mentioned this in D7472: Fix T75845: some dependencies update missing when painting textures..Apr 21 2020, 9:32 AM

Philipp Oeser (lichtwerk) mentioned this in T76251: Animated procedural texture does not influence particle system.Apr 30 2020, 9:27 AM

Philipp Oeser (lichtwerk) retitled this revision from Fix T65889: Hair Particles not updating in Viewport when using Influence Textures to Fix T65889: Hair Particles not updating in Viewport when using Influence Textures (image sequences).May 18 2020, 5:41 PM

Committed proper fixes at rB806db47fd8d and rB1335f2d2722.

Revision Contents
Changeset List

Path

Size

source/

blender/

depsgraph/

intern/

builder/

deg_builder_relations.cc

14 lines

Diff 15951

View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Fix T65889: Hair Particles not updating in Viewport when using Influence Textures (image sequences)AbandonedPublicActions