Page MenuHome
Differential D5123

Node Wrangler: Correct handling of disabled sockets.
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Jun 22 2019, 2:57 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBA3687f02a662d: Node Wrangler: correct handling of disabled sockets
Summary

Sometime, nodes have unavailable/disabled outputs. This patch makes sure those outputs are not connected by the Node Wrangler.

Diff Detail

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Jun 22 2019, 2:57 PM
Harbormaster completed remote builds in B3914: Diff 16038.Jun 22 2019, 2:57 PM
Omar Emara (OmarSquircleArt) edited the summary of this revision. (Show Details)Jun 22 2019, 3:01 PM
Omar Emara (OmarSquircleArt) added a reviewer: Jacques Lucke (JacquesLucke).
Jacques Lucke (JacquesLucke) requested changes to this revision.Jun 22 2019, 3:50 PM

It would probably be better to make an utility function like is_visible(socket) instead of duplicating that logic multiple times.

This revision now requires changes to proceed.Jun 22 2019, 3:50 PM
Omar Emara (OmarSquircleArt) added a comment.Jun 22 2019, 4:01 PM

@Jacques Lucke (JacquesLucke) A disabled socket can still be visible. Perhaps is_valid_socket(socket) would be a better name?

Omar Emara (OmarSquircleArt) added a comment.Jun 22 2019, 4:03 PM

@Jacques Lucke (JacquesLucke) Sorry, never mind, will do that.

Omar Emara (OmarSquircleArt) updated this revision to Diff 16039.Jun 22 2019, 4:11 PM
  • Add a utilitie function is_visible_socket
Harbormaster completed remote builds in B3915: Diff 16039.Jun 22 2019, 4:11 PM
Jacques Lucke (JacquesLucke) accepted this revision.Jun 22 2019, 5:03 PM
This revision is now accepted and ready to land.Jun 22 2019, 5:03 PM
Closed by commit rBA3687f02a662d: Node Wrangler: correct handling of disabled sockets (authored by Omar Emara (OmarSquircleArt), committed by Jacques Lucke (JacquesLucke)). · Explain WhyJun 27 2019, 5:24 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBA3687f02a662d: Node Wrangler: correct handling of disabled sockets.
Omar Emara (OmarSquircleArt) retitled this revision from Make sure output is enabled before connecting in node wrangler to Node Wrangler: Correct handling of disabled sockets..Aug 19 2019, 12:54 PM
Omar Emara (OmarSquircleArt) mentioned this in T68823: GSoC 2019 - Cycles/EEVEE Improvements.Aug 19 2019, 1:35 PM

Revision Contents
Changeset List

PathSize
12 lines

Diff 16094

View Options

node_wrangler.py

Loading...