Update Freestyle for 2.80
AbandonedPublic
Actions

Authored by Eitan Traurig (EitanSomething) on Jun 24 2019, 5:19 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Brendon Murphy (meta-androcto)

Summary

Update to Freestyle SVG Export for 2.80.Code was updated by mosest https://devtalk.blender.org/t/fix-for-freestyle-svg-export/8048

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Eitan Traurig (EitanSomething) created this revision.Jun 24 2019, 5:19 PM

Mohamed El Hamd (elbox01) awarded a token.Jun 24 2019, 7:09 PM

Brecht Van Lommel (brecht) added a reviewer: Brendon Murphy (meta-androcto).Jun 24 2019, 7:10 PM

Removed extra parenthesizes.

hi,
I am unsure of line 192 not using context and line 268 using context. Is there a reason for this?
The use of "mosesfreestyle" in the bl_location, surely this is an oversight?
Other than that this seems a very simple fix and most welcome.

This revision now requires changes to proceed.Jun 25 2019, 4:02 AM

In D5127#116476, @Brendon Murphy (meta-androcto) wrote:

hi,
I am unsure of line 192 not using context and line 268 using context. Is there a reason for this?
The use of "mosesfreestyle" in the bl_location, surely this is an oversight?
Other than that this seems a very simple fix and most welcome.

I'm asking
mosest what was broken without the line changes on 192 and 268. He says that scene.render.layers.active was removed, I'm still looking into it.

Removed context from line 268 and replaced mosesfreestyle with Freestyle SVG Export

Removed extra parenthesizes.

Brendon Murphy (meta-androcto) mentioned this in rBAac8b28a008eb: render_freestyle_svg: update to 2.8 D5127.Jun 30 2019, 2:39 AM

hi, it turned out this patch was wrong. I corrected it, tested and committed the fix.

context.window.view_layer.freestyle_settings

was the correct line fix.

Revision Contents
Changeset List

Path

Size

render_freestyle_svg.py

10 lines

Diff 16059

View Options

Update Freestyle for 2.80AbandonedPublicActions