Page MenuHome
Differential D5128

Fix T63921: Unable to use confirm on release for keyboard shortcuts
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jun 24 2019, 6:13 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Commits
rB0516d49d0ca5: Fix T63921: Unable to use confirm on release for keyboard shortcuts
rB30bf48c9caee: Fix T63921: Unable to use confirm on release for keyboard shortcuts
Summary

The issue was that we were still working around a Xorg bug that has been solved since a very long time:
https://bugs.freedesktop.org/show_bug.cgi?id=22515
The second issue was that the global "confirm on release for mouse clicks" was used for keyboard shortcuts as well.

Diff Detail

Repository
rB Blender

Event Timeline

Sebastian Parborg (zeddb) created this revision.Jun 24 2019, 6:13 PM
Sebastian Parborg (zeddb) mentioned this in T63921: Execution of a predefined shortcut.
Campbell Barton (campbellbarton) accepted this revision.Jun 25 2019, 2:08 AM
This revision is now accepted and ready to land.Jun 25 2019, 2:08 AM
Closed by commit rB30bf48c9caee: Fix T63921: Unable to use confirm on release for keyboard shortcuts (authored by Sebastian Parborg (zeddb)). · Explain WhyJun 25 2019, 12:32 PM
This revision was automatically updated to reflect the committed changes.
Sebastian Parborg (zeddb) added a commit: rB30bf48c9caee: Fix T63921: Unable to use confirm on release for keyboard shortcuts.
Sebastian Parborg (zeddb) added a reverting change: rB6e016a451e00: Revert "Fix T63921: Unable to use confirm on release for keyboard shortcuts".Jun 26 2019, 5:56 PM
Sebastian Parborg (zeddb) reopened this revision.Jun 26 2019, 5:56 PM
This revision is now accepted and ready to land.Jun 26 2019, 5:56 PM
Sebastian Parborg (zeddb) updated this revision to Diff 16084.EditedJun 26 2019, 6:04 PM

Updated the patch to fix node shortcuts that relied on this being broken.

As mentioned in D5139, this will now be for 2.81

Brecht Van Lommel (brecht) added a comment.Jul 31 2019, 1:36 PM

This is fine to go in 2.81 now.

Sebastian Parborg (zeddb) closed this revision.Jul 31 2019, 6:02 PM
Sebastian Parborg (zeddb) added a commit: rB0516d49d0ca5: Fix T63921: Unable to use confirm on release for keyboard shortcuts.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
7 lines
3 lines

Diff 16056

View Options

source/blender/editors/transform/transform.c

Loading...
View Options

source/blender/editors/transform/transform_generics.c

Loading...