In D5133#116590, @Brecht Van Lommel (brecht) wrote:

• The choice of info instead of warning icon was intentional. Using warnings for this type of thing is not so common anymore I think.

Prompt to save is definitely a warning, while the current icon used is to provide information. For Windows it is the
currently recommended icon specifically for this purpose. Their current guidelines basically say to use warning icon for almost all purposes.

https://docs.microsoft.com/en-us/dotnet/framework/wpf/app-development/dialog-boxes-overview

And used in the current version of Word:

Used on Macs too...

• The dialog is not wide enough for longer filenames, and longer warnings messages related to image saving that can also include filenames.

It could certainly be made wider, although any width can potentially be too narrow. At some point an arbitrary choice must be taken.

Here is the dialog with a name so long it must be truncated, the middle of it replace the the dreaded "two-dot leader". LOL

• As far as I know some empty space to the left of the buttons is still standard on Windows, I don't know why this was changed.

Because it looks dumb. The OS version has a large space held out on the left to accommodate a large icon, but we don't have that. So the Windows (and mac) dialogs look nicely balanced and proportional while ours looks a bit lopsided and silly with the text all off to the left, tiny icon, and buttons scrunched to the right. This balance issue doesn't exist on the Mac version though because the "Don't Save" is on the left side, so aligned with the text.

Seems nice enough to me. But:

• I don't understand why the buttons are bigger on Windows. Why not just add the spacer on the left side so they match more?
• Doesn't make sense to me to use different warning icons on the different platforms - that just seems arbitrary.

Mac apps tend to either use the app icon or a warning symbol:

In D5133#116950, @William Reynish (billreynish) wrote: >

• I don't understand why the buttons are bigger on Windows. Why not just add the spacer on the left side so they match more?

Because there is absolutely no need or advantage to scrunching them up. I'm not sure what the bottom give you extra over the top version?

I'm not sure why there'd be a need to "match" in any way. If you Mac guys like your gap in there, that seems fine.

In D5133#116950, @William Reynish (billreynish) wrote:

• Doesn't make sense to me to use different warning icons on the different platforms - that just seems arbitrary.

Mac apps tend to either use the app icon or a warning symbol:

Yes, was just trying to find a way to make Brecht happy, who seemed under the (wrong) impression that warning icons aren't used.

The better solution is text wrapping. (for long file names)
Or you can just put the filename or path on the second line.

In some languages, this phrase will be longer:

• Save changes to "Untitled" before closing?
• Сохранить изменения в файле "Untitled" перед закрытием?

And of course the warning icon is most appropriate.
Or "question mark" icon as an alternative.

In D5133#116961, @Yevgeny Makarov (jenkm) wrote:

The better solution is text wrapping. (for long file names)...

• Сохранить изменения в файле "Untitled" перед закрытием?

Good point. I know we have text wrapping code around somewhere so will look into that

Because there is absolutely no need or advantage to scrunching them up. I'm not sure what the bottom give you extra over the top version?

I'm not sure why there'd be a need to "match" in any way. If you Mac guys like your gap in there, that seems fine.

Windows never use stretched buttons on dialogs, IMO the proposal at bottom seems better and makes Blender less different between OS

@Matias Mendiola (mendio) - Windows never use stretched buttons on dialogs, IMO the proposal at bottom seems better and makes Blender less different between OS

Thanks for the input!

What bothers me personally about that is the funny alignment with the text aligned left and buttons to the right. What helps *me* with this is to add a rule in between like the following. It mimics the way the buttons are in a differently-colored area on the OS version.

What do you think? Hate it? Like? Harmless? Unnecessary?

In D5133#116966, @Harley Acheson (harley) wrote:

That line needs to go imho. Everything else looks fine, even though I still prefer the "Yes | No | Cancel" scheme. 😉

Another problem here is the checkbox next to the icon.
This is an important checkbox but it is lost, it looks like a simple informing icon.

As an option, do not use the icon:

"Save modified image."
Here for clarity, it is necessary to add something like "as well" or "also".

@Harley Acheson (harley) @William Reynish (billreynish)

I have some changes for this patch.

Patch with changes:

Screenshots:

The x2 scale:

Nice tweaks to the padding @Yevgeny Makarov (jenkm)! +1

@Yevgeny Makarov (jenkm) - I have some changes for this patch.

Absolutely love every change.

I had no idea that UI_block_bounds_set_centered() was the source of our non-scaled outer padding. That has been a surprisingly large source of frustration for us.

Thank you so much!

Excellent that you managed to get the margins sorted out. This is now a solid improvement.

What about the idea of adding "as well" to the message about saving images?

"as well" sounds wrong to me, I don't remember ever seeing that in a user interface.