Differential D5138

Proposed fix for T66126
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Jun 26 2019, 11:54 AM.

Tags

Subscribers

None

Details

Reviewers

Dalai Felinto (dfelinto)

Commits

rB4f3f68df3005: Fix T66126: Non-active Grease Pencil object stuck in draw mode

Summary

Now, the mode is reset.

Diff Detail

Event Timeline

Antonio Vazquez (antoniov) created this revision.Jun 26 2019, 11:54 AM

Antonio Vazquez (antoniov) mentioned this in T66126: Non-active Grease Pencil object stuck in draw mode.

Rename function (remove _ex subfix).

Did you test without my partial fix? Otherwise to reproduce the issue you have to recreate it from scratch since I fixed for loading files

@Dalai Felinto (dfelinto) I recreated the file using the steps you put in the task.

Added more context lines to see better the change (-U100)

Cleanup style for flags
Add GPencil modes to OB_MODE_ALL_MODE_DATA

@Dalai Felinto (dfelinto) what is the status of this patch? do I need change anything else?

Dalai Felinto (dfelinto) accepted this revision.Jun 28 2019, 1:44 PM

This revision is now accepted and ready to land.Jun 28 2019, 1:44 PM

Closed by commit rB4f3f68df3005: Fix T66126: Non-active Grease Pencil object stuck in draw mode (authored by Antonio Vazquez (antoniov)). · Explain WhyJun 28 2019, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB4f3f68df3005: Fix T66126: Non-active Grease Pencil object stuck in draw mode.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

gpencil/

24 lines

include/

1 line

object/

7 lines

Diff 16073

source/blender/editors/gpencil/gpencil_edit.c

Loading...

source/blender/editors/include/ED_gpencil.h

Loading...

source/blender/editors/object/object_modes.c

Loading...