Fix T66146: Node Editor: Node Actions not started from the mouse are directly confirmed
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jun 26 2019, 5:00 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Summary

There were some keybindings that was relying on the previously broken state of "confirm on release" for keyboard shortcuts.
These shortcuts should now be fixed for the node editor.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) created this revision.Jun 26 2019, 5:00 PM

Sebastian Parborg (zeddb) mentioned this in T66146: Node Editor: Node Actions not started from the mouse are directly confirmed.

Please revert rB30bf48c9caee: Fix T63921: Unable to use confirm on release for keyboard shortcuts, and then it can be committed again with this change after 2.80 is out. I do not want to risk breaking keymaps to support a feature that didn't work in 2.79 either.

This revision is now accepted and ready to land.Jun 26 2019, 5:40 PM

Sebastian Parborg (zeddb) closed this revision.Jun 26 2019, 6:00 PM

Sebastian Parborg (zeddb) mentioned this in D5128: Fix T63921: Unable to use confirm on release for keyboard shortcuts.Jun 26 2019, 6:06 PM