Details

Reviewers

William Reynish (billreynish)
Richard Antalik (ISS)

Commits

rBfbc90ae2bfb1: UI: Sequencer Sidebar Text-Strip Panel adjustments

Summary

The values in the Text strip panel are causing confusion: T65458

Icons has since then been added, but it is still possible to see the alignments as presets for the location values 0c2c57167bb5 This and a general 2.80 styled clean up of the panel is included in this diff.

In the before panel, has the "Export Subtitles been moved into the View menu under the export related render options.

BEFORE:

In the after panel the text is on top and as wide as possible, since the before width was only half width and imo too narrow.

The functions are now divided into two nested sub panels, since it makes it easier to navigate through the options.

The Location values are moved above the Alignment values, to avoid the confusion that the alignment values could be presets for the location.

In the menu and context menu the Text Effect strip was among the functions which had the Input sub menu visible. Text strips do not take strip inputs, so this is a bug, which is solved with this diff.

AFTER:

Diff Detail

Event Timeline

Peter Fog (tintwotin) created this revision.Jun 27 2019, 12:20 AM

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Jun 27 2019, 12:23 AM

William Reynish (billreynish) accepted this revision.Jun 27 2019, 10:22 AM

This revision is now accepted and ready to land.Jun 27 2019, 10:22 AM

Perhaps Alignment X/Y would work better in this case - takes up less space and fits more with Location X/Y. The misaligned Shadow checkbox should be fixed separately by T65965.

Also, perhaps we should rename the sub-panel to Placement rather than Location, since the Location string is already present inside it.

Location(in header) renamed to Layout
Alignment renamed to Alignment X/Y
Shadow renamed to Use Shadow.
Separated the shadow checkbox line from the color.
Shadow Color is the label on the shadow color.
Added the Input menu to the Text Menu/Context options.

Do you want to commit this(and similar) patches in this release?
Because I can approve this, if any of you want to take over work on manual.

I already lost track of what has been changed, so I will have to go through _all _chapters again. Apart from that I will do T65845 and should be done.

I don't know how bad are some inaccuracies in screenshots. But given, that we were thinking about leaving some from 2.79 not that bad I guess.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Jul 5 2019, 6:32 PM

@Richard Antalik (ISS) Maybe this and other Sequencer commits which will not make it into 2.80 RC1 could be added here: https://developer.blender.org/tag/bf_blender:_after_release/

Moved "Export Subtitles" into the Sequencer View Menu, and positioned it under the export related render options, since file export buttons do not belong in the Strip Properties Sidebar.

I'm not such a fan of the way Use Shadow works here - the relationship to the Shadow Color is unclear.

Ideally we would do this: