Sequencer: Add fade in, out & both for audio and video
AbandonedPublic
Actions

Authored by Peter Fog (tintwotin) on Jun 28 2019, 5:00 PM.

Details

Reviewers

Richard Antalik (ISS)
Brecht Van Lommel (brecht)
William Reynish (billreynish)

Summary

With the new dynamic waveform drawing, I feel the options to add audio fade ins & outs was missing. They are included in this diff.

(Click to watch the gif)

Using the code from KinoRaw this diff also adds video fade ins/outs:
(Click to watch the gif)

Fade Settings popup:

'Fade to/from Playhead' as requested by @david mcsween (davidmcsween):

Currently missing:

Remove old keyframes, but only from the ranges where new fade keyframes are inserted
Interactively update graph and waveform drawing when changing values in Fade Settings

Diff Detail

Event Timeline

Peter Fog (tintwotin) created this revision.Jun 28 2019, 5:00 PM

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Jun 28 2019, 5:02 PM

Nice feature. Ideally we should really also then add overlays on the clips so you can judge the fade over time.

In any case we aren’t adding features now, so this would be for a later release.

Silas Opel (Schamph) awarded a token.Jun 29 2019, 4:18 PM

This update adds a Fade Settings popup:

And Fade to/from Playhead as requested by @david mcsween (davidmcsween):

@Nathan Lovato (gdquest) has offered to clean up the code of ExecuteFadeInOut using his own operator from Power Sequencer.

Currently missing:

Remove old keyframes, but only from the ranges where new fade keyframes are inserted
Interactively update graph and waveform drawing when changing values in Fade Settings

We don't use popups for this kind of thing, instead the convention is to allow interactive tweaking from the adjust last operation panel.

Further, operators should not change the current frame like this because any unkeyed changes will be unexpectedly lost. Instead pass the frame as an argument to keyframe_insert.

We've discussed this on the vse channel on blender.chat. I'm on it, wrote an operator with more features today. The code is almost ready, I'm just running out of time tonight to finish testing and open the diff. I'll open it tomorrow.

In D5152#117116, @Brecht Van Lommel (brecht) wrote:

We don't use popups for this kind of thing, instead the convention is to allow interactive tweaking from the adjust last operation panel.

Is this the 'adjust last operation panel'? That would be the optimal way, but I couldn't get it to work in the sequencer and later I was told on the Blender python chat that this wasn't implemented in the sequencer. So popup is a workaround.

Adjust Last Operation should be added to all editors, except data views like File Browser, Properties and Outliner.

@Brecht Van Lommel (brecht) do we have a todo for this somewhere?

david mcsween (davidmcsween) awarded a token.Jul 2 2019, 12:24 PM

Nathan Lovato (gdquest) mentioned this in D5166: Sequencer: Add operators to add and remove fades.Jul 2 2019, 2:14 PM

I just put up a new patch as a suggestion to replace this one: https://developer.blender.org/D5166
It adds a flexible fade add operator, with hopefully more flexible code so we can keep improving it moving forward. It's a core operation when it comes to video editing so it should be rock-solid.

Peter Fog (tintwotin) mentioned this in T66462: Sequencer: Adjust Last Operation is missing from the Sequencer View Menu.Jul 5 2019, 1:00 PM

Peter Fog (tintwotin) abandoned this revision.Jul 8 2019, 10:06 PM