Page MenuHome
Differential D5154

Fix Sapling addon object fake user bug
ClosedPublic
Actions

Authored by CansecoGPC (CansecoGPC) on Jun 30 2019, 5:59 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Summary

The add-on tries to deselect all objects before doing anything, but fails when it founds a previously deleted object with fake user.

Diff Detail

Event Timeline

CansecoGPC (CansecoGPC) created this revision.Jun 30 2019, 5:59 PM
CansecoGPC (CansecoGPC) added subscribers: Jacques Lucke (JacquesLucke), Brendon Murphy (meta-androcto).Jul 3 2019, 11:14 AM

Could somebody take a look at this simple patch, @Jacques Lucke (JacquesLucke), @Brendon Murphy (meta-androcto)?

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Jul 15 2019, 10:57 AM

Note the correct way to deselect all objects would be looping over all objects in the view layer with for ob in bpy.context.view_layer.objects.

Jacques Lucke (JacquesLucke) added a comment.Jul 15 2019, 11:02 AM

Right, also when iterating over the objects in a the view layer, you should not have a problem with objects that are already deleted.

CansecoGPC (CansecoGPC) updated this revision to Diff 16398.Jul 15 2019, 3:59 PM

Changed from deselecting objects on file to view layer.

CansecoGPC (CansecoGPC) added a comment.Jul 15 2019, 4:00 PM

Bug report related to this patch, https://developer.blender.org/T66252

Brecht Van Lommel (brecht) accepted this revision.Jul 15 2019, 4:45 PM
This revision is now accepted and ready to land.Jul 15 2019, 4:45 PM
Brendon Murphy (meta-androcto) mentioned this in rBAea0873dedaa1: add_curve_sapling: Fix: T66252 D5154.Jul 16 2019, 1:29 PM
Brendon Murphy (meta-androcto) closed this revision.Jul 16 2019, 1:33 PM

Revision Contents
Changeset List

PathSize
add_curve_sapling/
6 lines

Diff 16130

View Options

add_curve_sapling/utils.py

Loading...