Fix T66311: skin resize (ctrl+a) could crash
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jul 2 2019, 10:52 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Maniphest Tasks

T66311: crash when you use skin resize(ctrl+a) on two objects with multi edit, when skin modifier applyes only to one of objects

Commits

rBc6a199e2542b: Fix T66311: skin resize (ctrl+a) could crash

Summary

could happen when used on multiple objects with multi edit, and skin
modifier was not present on all participating objects

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jul 2 2019, 10:52 AM

Harbormaster completed remote builds in B3952: Diff 16155.Jul 2 2019, 10:52 AM

Brecht Van Lommel (brecht) requested changes to this revision.Jul 3 2019, 4:29 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/editors/transform/transform_ops.c
764	The standard method to loop over objects in edit mode appears to be `BKE_view_layer_array_from_objects_in_edit_mode_unique_data`.

This revision now requires changes to proceed.Jul 3 2019, 4:29 PM

use BKE_view_layer_array_from_objects_in_edit_mode_unique_data (instead of CTX_data_selected_editable_objects)

Harbormaster completed remote builds in B3957: Diff 16174.Jul 3 2019, 5:33 PM

Philipp Oeser (lichtwerk) marked an inline comment as done.Jul 3 2019, 5:39 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 3 2019, 5:42 PM

This revision is now accepted and ready to land.Jul 3 2019, 5:42 PM

Closed by commit rBc6a199e2542b: Fix T66311: skin resize (ctrl+a) could crash (authored by Philipp Oeser (lichtwerk)). · Explain WhyJul 3 2019, 5:54 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBc6a199e2542b: Fix T66311: skin resize (ctrl+a) could crash.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_conversions.c

15 lines

transform_ops.c

23 lines

Diff 16176

View Options

source/blender/editors/transform/transform_conversions.c